feat(oauth): add owner app freeze, delete, and richer client settings - #68
Merged
Conversation
Owners can now suspend (freeze) or permanently delete their OAuth apps from the dashboard, and edit the app name, post-logout redirect URIs, allowed scopes, grant types, and refresh-token issuance. A new frozen status sits beside admin-only disabled; every enforcement path already requires status = active, so frozen apps are rejected at authorize, token, userinfo, introspection, and the activation API with no enforcement changes, and their issued tokens stop validating until unfrozen. Guarded transitions keep owners from reviving admin-disabled apps and admins from overriding an owner freeze. Deletion cascades tokens, secrets, codes, webhook endpoints, and authorizations, and clears any stashed bearer plaintext key first. Destructive controls now wear a pastel red fill at rest (new danger tokens, filled Button danger variant, Section danger tone) so dangerous actions read as dangerous before hover, in the app pages and settings.
getAll on the permissions form can carry duplicate values from a tampered submit. Collapse them the way parseOAuthScopes already does for the authorize path, so the stored allowlist stays a clean set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Developer-experience pass on the OAuth app dashboard.
What
Decisions worth review
Tests: integration coverage for freeze transitions, ownership guards, cap counting, and delete cascades in tests/integration/external-app-owner-lifecycle.test.ts.