fix: repair RC release preflight#26
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6625841d8f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: Commit and tag RC version | ||
| run: | | ||
| git add .cz.toml | ||
| git commit -m "chore: release ${{ steps.version.outputs.version }}" |
There was a problem hiding this comment.
Preserve the tag-recovery retry path
When a retry starts from next after the branch already contains the prepared .cz.toml version but the tag was not created or pushed (for example, a non-atomic git push ... --follow-tags updated the branch ref and rejected the tag), prepare-rc-release.js computes the same RC version and leaves nothing staged. Because this line no longer permits an empty release commit, the workflow fails here before it can recreate the missing tag; either require/advance a changed .cz.toml or keep the empty-commit fallback for that recovery case.
Useful? React with 👍 / 👎.
Problem
The RC workflow failed before build and publication because
verify-release-readiness.jsrequired an untracked performance report that hasno producer in the repository.
The failed run created no release commit, tag, artifact publication, or GitHub
release.
v3.1.0-rc.16remains available.Fix
.cz.toml, branch, tag availability, and changed filesbuild,rcVerify, JMH compilation, binary compatibility, and source-archive verification before taggingrc-releaseenvironment hook for optional approval protectionVerification
./gradlew rcVerify jmhClasses: passedgit diff --check: passedRetry behavior
Merging this PR into
nextstarts a fresh RC workflow. Do not rerun the previous failed job because it uses the broken workflow revision.