feat: add dexAbstraction to the abstraction enum surfaces - #79
Merged
Conversation
- UserAbstractionResponse (info) and webData3.abstraction (subscription) gain the value per the documented enum (type-only, responses are not runtime-validated) - userSetAbstraction (exchange) picklist accepts dexAbstraction: verified against the live exchange deserializer (passes structural validation where a garbage value 422s). It has no single-letter wire form, so the multi-sig payload mapping passes the full name through unchanged. - Tests: live coverage ignores for the unproducible branches (no testnet account in that mode; flipping the shared account would leak), an offline multi-sig passthrough case, and a webData3 delivery pinning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dexAbstraction(documented in the abstraction enum:unifiedAccount | portfolioMargin | disabled | default | dexAbstraction) to the three surfaces that lacked it:UserAbstractionResponse(info)dexAbstractionwebData3.abstraction(subscription)dexAbstractionuserSetAbstractionpicklist (exchange)dexAbstractionMulti-sig:
dexAbstractionhas no single-letter wire form, sotoMultiSigPayloadActionpasses the full name through unchanged (pinned by a new offline test).Live schema-coverage tests ignore the new branches with comments (no testnet account exists in dexAbstraction mode, and flipping the shared live account would leak state into other tests); offline batteries pin the new value on all three surfaces.