Change to errored status if belamor returns error - #465
Draft
Nitr wants to merge 1 commit into
Draft
Conversation
Nitr
force-pushed
the
wothdrawal_errored_on_send_coins
branch
2 times, most recently
from
October 9, 2022 05:11
d59322d to
28b4ea5
Compare
Nitr
force-pushed
the
wothdrawal_errored_on_send_coins
branch
from
October 10, 2022 13:38
28b4ea5 to
6b09f3e
Compare
huryv45
reviewed
Oct 12, 2022
| remote_id: id, | ||
| meta: { note: note } | ||
| ) | ||
| rescue StandardError => e |
Contributor
There was a problem hiding this comment.
а какую ошибку отдает Belomor? нельзя делать rescue на BelomorClient::Error или Belomor::WrongResponse?
cо StandardError очень легко важные ошибки пропустить
Contributor
Author
There was a problem hiding this comment.
а как пропустить? мы же их в багснаг отправляем и вывод в errored отправляем.
можно наврено Faraday::Error отлавливать вместо StandardError
Contributor
There was a problem hiding this comment.
я за Faraday::ConnectionFailed
Contributor
Author
There was a problem hiding this comment.
Еще BelomorClient не райзит ошибки, он просто возвращает :bad_request
radanisk
marked this pull request as draft
November 1, 2022 10:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.