fix(send): reject eligible inputs without private keys - #63
Merged
Conversation
reez
marked this pull request as ready for review
July 20, 2026 20:02
sdmg15
reviewed
Jul 21, 2026
nymius
requested changes
Jul 22, 2026
nymius
approved these changes
Jul 23, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Looking through
derive_spI noticed it can continue when the private key for an eligible input is missing as long as it finds a key for another input. That gives the sender an incomplete input key sum which won’t match what the receiver calculates, so this PR returnsKeyErrorinstead. (Inputs that aren’t eligible for silent payments are still skipped)Notes to the reviewers
Added coverage for a missing key among multiple eligible inputs and for skipping an ineligible input.
Changelog notice
Return an error when an eligible silent payment input key is missing.
Checklists
All Submissions:
just p(fmt, clippy and test) before committingNew Features:
Bugfixes: