Skip to content

fix: remove temporary esplora panic handling - #1107

Merged
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:catchunwind
Sep 2, 2026
Merged

fix: remove temporary esplora panic handling#1107
reez merged 1 commit into
bitcoindevkit:masterfrom
reez:catchunwind

Conversation

@reez

@reez reez commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Removes the temporary catch_unwind wrappers added in #863.

Notes to the reviewers

  • bdk-ffi#869 tracked removing the temporary wrappers after upstream fixes landed.
  • bdk#1971 fixed the wrong network panic that originally prompted the workaround.
  • bdk#2053 added my upstream stop gap panic fix.
  • bdk#2148 backported that fix into bdk_esplora 0.22.2, which bdk-ffi now uses.

Documentation

Changelog

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added exactly one changelog:* label
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@thunderbiscuit thunderbiscuit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0832a82.

@reez
reez merged commit d7d002c into bitcoindevkit:master Sep 2, 2026
8 of 9 checks passed
@reez
reez deleted the catchunwind branch September 2, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants