Skip to content

ci: Compile with minimum supported g++ in olddeps - #330

Merged
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
maflcko:2608-ci-gcc-11
Aug 3, 2026
Merged

ci: Compile with minimum supported g++ in olddeps#330
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
maflcko:2608-ci-gcc-11

Conversation

@maflcko

@maflcko maflcko commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Looks like there is no CI coverage for the minimum supported g++ version?

@DrahtBot

DrahtBot commented Aug 2, 2026

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK ryanofsky

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #175 (Set cmake_minimum_required(VERSION 3.22) by maflcko)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto

hebasto commented Aug 2, 2026

Copy link
Copy Markdown
Member

ci: Compile with minimum supported g++-11 in olddeps

It seems g++10 is the minimum supported.

@maflcko maflcko changed the title ci: Compile with minimum supported g++-11 in olddeps ci: Compile with minimum supported g++ in olddeps Aug 3, 2026

@ryanofsky ryanofsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK edf6343. Would maybe change title to "Compile with older GCC in olddeps" because it's not clear what the real minimum is. (Or if it is clear it would be nice to document).

Also this is only testing libmultiprocess build with the older GCC, so using older GCC for capnproto as well could be more realistic, but this PR is probably the simplest change

@ryanofsky
ryanofsky merged commit f13c64a into bitcoin-core:master Aug 3, 2026
13 checks passed
@maflcko
maflcko deleted the 2608-ci-gcc-11 branch August 4, 2026 06:20
@maflcko

maflcko commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Would maybe change title to "Compile with older GCC in olddeps" because it's not clear what the real minimum is. (Or if it is clear it would be nice to document).

Happy to do this, but not sure how. Should I cherry-pick bitcoin/bitcoin#34580 into this repo ?

Also this is only testing libmultiprocess build with the older GCC, so using older GCC for capnproto as well could be more realistic, but this PR is probably the simplest change

This seems like something for upstream to do. Recall they already have Linux-old (g++-9) config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants