Skip to content

ci: Switch back to Bitcoin Core's master branch - #322

Closed
hebasto wants to merge 1 commit into
bitcoin-core:masterfrom
hebasto:260729-ci-core
Closed

ci: Switch back to Bitcoin Core's master branch#322
hebasto wants to merge 1 commit into
bitcoin-core:masterfrom
hebasto:260729-ci-core

Conversation

@hebasto

@hebasto hebasto commented Jul 29, 2026

Copy link
Copy Markdown
Member

bitcoin/bitcoin#35084 has now been merged.

@DrahtBot

DrahtBot commented Jul 29, 2026

Copy link
Copy Markdown

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline and AI policy for information on the review process.

Type Reviewers
ACK Sjors

If your review is incorrectly listed, please copy-paste <!--meta-tag:bot-skip--> into the comment that the bot should ignore.

@Sjors

Sjors commented Jul 29, 2026

Copy link
Copy Markdown
Member

ACK 9a0ba89

@hebasto

hebasto commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

Apparently, Bitcoin Core needs a patch:

--- a/src/ipc/capnp/protocol.cpp
+++ b/src/ipc/capnp/protocol.cpp
@@ -9,6 +9,7 @@
 #include <ipc/capnp/protocol.h>
 #include <ipc/exception.h>
 #include <ipc/protocol.h>
+#include <ipc/util.h>
 #include <kj/async.h>
 #include <mp/proxy-io.h>
 #include <mp/proxy-types.h>
--- a/src/ipc/util.h
+++ b/src/ipc/util.h
@@ -53,12 +53,12 @@ inline SocketId StartSpawned(const std::string& connect_info)
     if (!socket) throw std::invalid_argument(strprintf("Invalid socket descriptor '%s'", connect_info));
     return *socket;
 }
+#endif
 
 inline ThreadContext& CurrentThread()
 {
     return g_thread_context;
 }
-#endif
 } // namespace mp
 
 #endif // BITCOIN_IPC_UTIL_H

@Sjors

Sjors commented Jul 29, 2026

Copy link
Copy Markdown
Member

Probably easiest to wait for #318.

Oh no, CI will always fail. I opened #323 to match the shim, and switch to master there.

@hebasto

hebasto commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

Closing in favour of #323.

@hebasto hebasto closed this Jul 29, 2026
ryanofsky added a commit that referenced this pull request Jul 30, 2026
…i: switch Bitcoin Core to master

66298c7 ci: Switch back to Bitcoin Core's master branch (Hennadii Stepanov)
86b4810 refactor: access ThreadContext through CurrentThread() (Sjors Provoost)

Pull request description:

  This is a minimal subset from #318 needed to match the shim introduced by bitcoin/bitcoin#35084. Should unblock #322, see #322 (comment).

  Include #322 here, because CI will not pass now since bitcoin/bitcoin#35084 merged.

ACKs for top commit:
  xyzconstant:
    ACK 66298c7
  hebasto:
    ACK 66298c7.
  ViniciusCestarii:
    ACK 66298c7
  ryanofsky:
    Code review ACK 66298c7. This nicely separates the `CurrentThread` refactoring from the mingw bug workaround. But it's misleading to call this a minimal fix for compatibility, because a minimal fix would just be:

Tree-SHA512: 04cdb9f72c01279a7d9d8bd5735be5114dc6c37a5c66c5cab3e199d48c42da30d2db4c0bcd4f3bcf5508a04a52c78d63945b7ea9b605624353478872d38c5ebe
@hebasto
hebasto deleted the 260729-ci-core branch July 30, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants