fix: WebView2 version single-source-of-truth + bump to 1.0.4078.44 - #43
Merged
Conversation
…) + bump to 1.0.4078.44 The WebView2 version was hardcoded in src/Tiny11.WebView2.psm1 ($PinnedVersion = 1.0.2535.41) AND declared in the launcher csproj. Dependabot bumps only the csproj, so the module kept resolving the OLD NuGet path -- the "finds the NuGet-restored DLLs" Pester integration test then failed (why WebView2 bump PR #39 was red). - Get-Tiny11WebView2Version reads the version from the launcher csproj's PackageReference, so the module always follows the csproj. No hardcoded copy, no drift, no second edit on a bump. - Tests derive the expected version the same way (were hardcoded to 1.0.2535.41), plus coverage for the new resolver. - Applied the bump that exposed this: Microsoft.Web.WebView2 -> 1.0.4078.44 (supersedes #39). Verified locally: dotnet build clean; all 14 WebView2 Pester tests pass, including the integration test that was failing.
bilbospocketses
enabled auto-merge (squash)
July 18, 2026 21:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
src/Tiny11.WebView2.psm1now resolves the WebView2 versionfrom the launcher csproj (
Get-Tiny11WebView2Version) instead of a hardcoded$PinnedVersion = 1.0.2535.41. The module follows the csproj automatically.Microsoft.Web.WebView2→ 1.0.4078.44(supersedes chore(deps): Bump Microsoft.Web.WebView2 from 1.0.2535.41 to 1.0.4078.44 #39).
Why
The version lived in two places (module + csproj). Dependabot only bumps the csproj, so the
module kept pointing at the OLD NuGet path and the
finds the NuGet-restored DLLsPesterintegration test failed — that's why #39 (the WebView2 bump) went red. Now a bump flows
through with no second edit.
Verification
dotnet buildclean; all 14 WebView2 Pester tests pass, including the integration testthat was failing on #39.