Fixing #3165 - #3166
Closed
mrinc wants to merge 1 commit into
Closed
Conversation
Fixes case where htmx is loaded async and DOMContentLoaded is never fired.
Collaborator
|
Sorry, we've been through the ringer on this one and simply don't support loading htmx as a module this way. We make a good-faith effort but if what we have right now doesn't work you will need to do your own workaround. I think we'd still be okay with exposing an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes case where htmx is loaded async and DOMContentLoaded is never fired.
By using window.onload as well, we cover the case where it is not fired.
No change to current behavior but fixes the case of dynamically loading htmx.
Corresponding issue: #3165
Testing
Lets discuss how we should test this one and then can just update the test suite accordingly.
It's specific case where the htmx lib is loaded async.
htmx itself operates the same, the big issue occurs when you try go back in the browser (I could be missing something...).
However this does bring up other notes where the ready function isn't run - so we should be testing for that currently.
So it's not just, lets add a single test case, it's we should add a single test case for the ready function in the 2 cases, but we should also be running all the tests again, in an async loaded state to make sure htmx behaves the same in both load-state cases.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded