Move idiomorph-htmx extension over from Idiomorph repo - #146
Open
botandrose wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for htmx-extensions canceled.
|
✅ Deploy Preview for htmx-extensions canceled.
|
Author
|
Hi folks, I'm preparing an Idiomorph v0.8.0 release, which is shaping up to largely be a bugfix and garbage collection release. I'd love to be able to finally remove the htmx extension from the Idiomorph repo into this one as a part of that release. @1cg and I had discussed performing this move this late last year, but better late than never. Any reason not to do this now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the idiomorph-htmx extension over from the Idiomorph repo. I'm trying to slim down Idiomorph's core at the moment, and this repo seems like the correct place for this code, anyways, since htmx composes Idiomorph, and not vice-versa.
I also moved the test suite over from Idiomorph, as well, and got it passing.
Lastly, I'm not familiar with htmx, so I may have done something wrong or suboptimal here.
Open questions
Maybe you'll want to name this extension something else? It was just named "morph" in the Idiomorph src, but I changed it to "idiomorph" here for consistency.
Checklist
npm run test) and verified that it succeeded