Model the contact thread list: page cursor and postings on GetContact - #127
Merged
Conversation
A contact's JSON has always carried one page of the threads they are on -- the list HEY heads "All threads with GitHub" -- but the SDK dropped the postings, the heading and the Link cursor. Model them, and add Contacts().ThreadsPage for the cursor-bearing read. Bumps the Go SDK version to 0.27.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contact's JSON has always carried one page of the threads they are on — the list HEY heads "All threads with GitHub" — but the SDK dropped the
postings, theentries_titleheading, and theLinkcursor. No server change involved; this models what the endpoint already serves.API surface
pagequery parameter toGetContactandentries_title+postingstoContactDetail.ContactPageandContacts().ThreadsPage(ctx, contactID, cursor): an empty cursor starts at the top, the next page's cursor is read from the responseLinkheader, following the page-read pattern.Contacts().Getkeeps its signature and one-page behavior.Proof
pagequery, and the last page answers no cursor.make checkpasses: Go tests and lint green, generated artifacts current, all 167 conformance cases pass.Risk and reviewer focus
Low: the parameter and fields are additive and the existing
Getis unchanged. Please focus on theContactDetailadditions matching the served JSON.Consumer
hey-cli's TUI: opening a fully read bundle shows the contact's thread list (the web app's behavior), where today it dead-ends on an empty screen. Follows up basecamp/hey-cli#337.