Prevent indentation after Markdown line breaks - #345
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Prevents Markdown line breaks from adding indentation when converted to HEY-compatible HTML.
Changes:
- Adds a Goldmark text renderer that emits
<br>without trailing whitespace. - Expands regression coverage across HTML utilities, CLI commands, drafts, and TUI composition.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
internal/htmlutil/from_markdown.go |
Adds whitespace-free line-break rendering. |
internal/htmlutil/from_markdown_test.go |
Covers breaks and structural whitespace. |
internal/cmd/compose_test.go |
Verifies raw HTML preservation. |
internal/cmd/contacts_test.go |
Updates contact-note output expectation. |
internal/cmd/draft_test.go |
Tests flush draft continuation lines. |
internal/cmd/forward_test.go |
Updates forwarded-content expectation. |
internal/tui/compose_test.go |
Updates TUI composition expectation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Markdown-authored content with a hard line break included a formatting newline after
<br>. HEY preserved that whitespace, making continuation lines appear indented.Before
After
The corrected output applies to Markdown-authored messages, drafts, forwards, and contact notes while preserving structural whitespace in paragraphs, lists, blockquotes, code blocks, and raw HTML.
Validation
GOWORK=off make checkGOWORK=off make buildGOWORK=off go test -cover ./internal/htmlutil -count=1— 93.4% statement coverage