feat: add configurable cookie notice - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement the configurable first-visit cookie and local-storage notice in the terminal.
Implementation
Behavior and compatibility
The notice is disabled when cookieNotice.enable is false. Existing string-form cookieNotice values remain supported. This PR depends on refactor/config-path.
Risk
The main risk is repeated prompting or incorrect consent persistence; focused tests cover parsing and storage behavior.
Verification
All checks passed, including desktop and mobile browser interaction checks.
Checklist