Fix filepath collisions 2 - #19
Open
milahu wants to merge 3 commits into
Open
Conversation
Problem: The previous implementation couldn't handle cases where a HAR file contained entries for both a URL and its subpath (e.g., 'foo' and 'foo/bar'). This led to conflicts when trying to represent both as filesystem paths. Solution: - Implement 'ensureDir' function to create nested directory structure - Handle cases where a file exists where a directory is needed: - Move existing file to 'index' within a new directory - Replace 'makeDir.sync' with this new, more flexible approach This change allows us to correctly represent all HAR entries in the filesystem, even when URL paths overlap. For example: - 'server.com/foo' becomes 'server.com/foo/index' - 'server.com/foo/bar' becomes 'server.com/foo/bar' Testing: Manually tested with HAR files containing conflicting URL paths.
milahu
commented
Jun 10, 2026
| } | ||
|
|
||
| if (fs.existsSync(outputPath)) { | ||
| const fileStat = fs.lstatSync(outputPath); |
Author
There was a problem hiding this comment.
TODO handle if (fileStat.isFile()) { ... } by adding suffixes
file
file.1
file.2
file.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continue #13