Refactor channel inference in inferSubEpochChannels function to impro… - #26
Merged
Merged
Conversation
…ve file size validation and sample count handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates NeuroScope2 sub-epoch dat handling so that the channel count comes from
session.extracellular.nChannelsinstead of being inferred from the timestamp-derived sample count.Motivation
Some Intan datasets can have small timestamp gaps in
time.dat. In those cases,MergePoints.timestamps_samples/session.epochsmay report a sample span that is slightly longer than the actual number of samples stored inamplifier.dat.For example, one dataset had:
amplifier.dat: 157,831,296 actual samples at 128 channels int16MergePoints/session: 157,831,323 expected samplestime.dat: timestamp jump from 152,339,682 to 152,339,711The raw file size was valid for 128 channels, but channel inference failed because it used the timestamp-derived sample count.
Changes
session.extracellular.nChannelsas the authoritative channel count for sub-epoch dat files.nChannels * sampleBytes.Validation
NeuroScope2.mparses successfully with MATLABmtree.