fix(rust): resolve aws-lc-sys versions, add deduping in TestVectors - #951
Open
lucasmcdonald3 wants to merge 3 commits into
Open
fix(rust): resolve aws-lc-sys versions, add deduping in TestVectors#951lucasmcdonald3 wants to merge 3 commits into
lucasmcdonald3 wants to merge 3 commits into
Conversation
aws-lc-rs floats to its latest (1.18), which pulls aws-lc-fips-sys 0.14 and aws-lc-sys 0.44. The Rust runtimes' direct -sys pins lagged at 0.13/0.39, so a second copy of aws-lc-fips-sys compiled and its FIPS symbols (which cannot be symbol-prefixed) collided when the test-vectors FIPS binary linked. Align the direct pins with aws-lc-rs in both runtime crates, and extend the duplicate-aws-lc gate to the test-vectors runtime, which it never covered.
Print the repo-relative path to the offending Cargo.toml, the exact line to change, and the aws-lc-rs version doing the resolving.
lucasmcdonald3
changed the title
lucasmcdonald3
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ex. from actual DBESDK message log
Squash/merge commit message, if applicable:
fix(rust): resolve aws-lc-sys versions, add deduping in TestVectors
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.