Skip to content

Bump pkg to v0.0.26 - #730

Merged
ack-prow[bot] merged 1 commit into
aws-controllers-k8s:mainfrom
knottnt:chore/update-pkg-v0.0.26
Aug 15, 2026
Merged

Bump pkg to v0.0.26#730
ack-prow[bot] merged 1 commit into
aws-controllers-k8s:mainfrom
knottnt:chore/update-pkg-v0.0.26

Conversation

@knottnt

@knottnt knottnt commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:
Upgrades pkg to v0.0.26 to apply aws-controllers-k8s/pkg#50

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow
ack-prow Bot requested review from jlbutler and michaelhtm August 13, 2026 00:11
@ack-prow ack-prow Bot added the approved label Aug 13, 2026
@gustavodiaz7722

Copy link
Copy Markdown
Member

/LGTM

@ack-prow ack-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@ack-prow

ack-prow Bot commented Aug 13, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gustavodiaz7722, knottnt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knottnt

knottnt commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@knottnt

knottnt commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@knottnt

knottnt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rdoshi1

rdoshi1 commented Aug 14, 2026

Copy link
Copy Markdown

The required ec2-controller-test is failing during bootstrap because the shared test account has reached its VPC quota. Could someone clean up the stale VPCs or address the quota, then comment /test ec2-controller-test on this PR?

@knottnt

knottnt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rdoshi1

rdoshi1 commented Aug 14, 2026

Copy link
Copy Markdown

Latest retry progressed past VPC creation but failed during EC2 bootstrap with TransitGatewayLimitExceeded. Cleanup then raised an AttributeError because the Transit Gateway was never created.

This PR only updates the pkg dependency in go.mod and go.sum, and the remaining checks pass, so this appears unrelated to the PR. Could a test-infra owner clean up the shared account’s Transit Gateways or restore its quota, then rerun /test ec2-controller-test?

Thank you!

@knottnt

knottnt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@rdoshi1

rdoshi1 commented Aug 14, 2026

Copy link
Copy Markdown

The latest ec2-controller-test progressed past the previous VPC and Transit Gateway quota failures. This time, 85 tests passed, while 7 failed and 3 errored because status.vpcID or status.transitGatewayID was not populated before the tests read it.

The controller logs also show shared-account cleanup issues, including an authorization failure while releasing an Elastic IP and subnet dependency violations. Since this PR only updates the pkg dependency and the controller successfully populated vpcID for other resources in the same run, this still appears likely to be shared test-account state or timing rather than a regression caused by this PR.

Could a test-infra owner clean up the shared EC2 resources and run ec2-controller-test against both this PR and current main? That comparison should confirm whether the failure is environmental or specific to this change. Thank you!

@rdoshi1

rdoshi1 commented Aug 14, 2026

Copy link
Copy Markdown

The latest retry passed all other checks, but EC2 and EKS failed on what appear to be unrelated shared-environment/timing issues:

  • EC2: missing status.vpcID/status.transitGatewayID values and cleanup failures.
  • EKS: the test checked authenticationMode before the asynchronous AWS update completed.

Could a test-infra owner run these tests against both current main and this PR to confirm they are unrelated, then rerun:

  /test ec2-controller-test
  /test eks-controller-test

@knottnt

knottnt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@knottnt

knottnt commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/test ec2-controller-test

@knottnt

knottnt commented Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@ack-prow
ack-prow Bot merged commit 328400d into aws-controllers-k8s:main Aug 15, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants