Standardize CI on the org shape - #5
Merged
Merged
Conversation
`go test ./...` was written out in both ci.yml and release.yml. It is .github/actions/test now, called by both -- a small duplication, but the same kind that lets the release-side copy be trimmed for speed until it no longer matches what people trust on a pull request. Build runs before Test, the job is named ci rather than cli, third-party actions are pinned by SHA, and both jobs are bounded. NOT fixed here, and noted in ci.yml: the two workflows still BUILD differently. CI runs scripts/cli_build.sh; release.yml cross-compiles inline with its own loop. Only the CI path runs on a pull request, so a break in the release cross-compile still surfaces first at release time. Unifying them means deciding which build is the real one and deserves its own pull request. Verified locally: vet and tests pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go test ./...becomes.github/actions/test, called by CI and Release. It was written out in both — a small duplication, but the kind that lets the release-side copy get trimmed for speed until it no longer matches what people trust on a pull request.cli→ci, third-party actions SHA-pinned, both jobs bounded.Deliberately not fixed here
The two workflows still build differently. CI runs
scripts/cli_build.sh;release.ymlcross-compiles inline with its own loop. Only the CI path runs on a pull request, so a break in the release cross-compile still surfaces first at release time — the exact failure the shared-action pattern exists to prevent.Unifying them means deciding which build is the real one, which is a judgement call with its own risk. It gets its own PR. This one stops the test drifting and leaves a note in
ci.ymlso the build split isn't mistaken for finished work.Verified locally:
go vetandgo testpass.Phase 5 of the standardization plan.