Add CI - #1
Merged
Merged
Conversation
This repository had no .github at all, while its three sibling -web repos -- gdam-web, gdlint-web, termcade-web -- all had one. Nothing has ever checked it. Build installs from the committed lockfile and builds; Test asserts the page was actually written, since a build that emits nothing still exits 0. pnpm, not bun. The other four -web repos in this organisation are bun with the version pinned in .mise.toml; this one has a pnpm-lock.yaml at lockfileVersion 9.0 and no .mise.toml. Installing what the committed lockfile describes is the right thing for a change that is only meant to add a check -- converting the lockfile and adopting mise is a separate change with its own risk, and doing both at once would make a build failure ambiguous. No no-JavaScript assertion, unlike the static sites in the nicodes organisation. This one ships Qwik: a build emits thirteen .js files on purpose, so that check would fail on its first run. Verified locally: install --frozen-lockfile and build both succeed, dist/index.html written, 33 files out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This repository had no
.githubat all, while its three sibling-webrepos —gdam-web,gdlint-web,termcade-web— all had CI. Nothing has ever checked it..github/actions/build— install from the committed lockfile, build.github/actions/test— the page was actually written.github/workflows/ci.yml— one job,pull_request+push: [main](no CD here, so nothing else covers a merge), SHA-pinned,timeout-minutes: 15pnpm, not bun
The other four
-webrepos in this org are bun with the version pinned in.mise.toml. This one has apnpm-lock.yamlatlockfileVersion 9.0and no.mise.toml.I install what the committed lockfile describes rather than converting it. Adding a check and migrating the package manager in one PR would make any build failure ambiguous — and the migration deserves its own decision. Flagging it as the one repo out of step with its family.
No no-JavaScript assertion
Unlike the nicodes static sites, this one ships Qwik — a build emits 13
.jsfiles on purpose, so that check would fail on its first run. The test action says so, to stop it being added later for consistency.Verified locally
pnpm install --frozen-lockfileandpnpm run buildboth succeed;dist/index.htmlwritten, 33 files out.Phase 3 of the standardization plan (F10).