Skip to content

[ticket-103] Fix repeated published adoption validation - #124

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/103-repeated-adoption-validation
Sep 10, 2026
Merged

[ticket-103] Fix repeated published adoption validation#124
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket/103-repeated-adoption-validation

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Ticket: ticket-103

Material change

Adopt published wellmanifest/new-project 0.20.22 at dc2240c22d49391845fef07f32664f37b904504f (source PR 320). This fixes fresh-main governance validation after multiple historical standard adoptions. The generator updates the managed payload; target-owned workflow and package metadata retain their behavior and bind only the new immutable revision.

No runtime changes, historical ticket rewrites, required-check removals or independent approval bypasses.

Verification

  • Managed governance: zero errors and warnings; immutable adoption is up-to-date.
  • make verify: 450 passed, 1 skipped, 0 failed (451 total).
  • make smoke: 227 records and 227 relations.
  • Docker smoke: passed.
  • Pre-commit overlap guard: passed for 11 checkouts.

Independent exact-head review and protected merge are required. After merge, verify fresh main CI and the managed gate in a clean clone without local terminal receipts.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator approval after policy checks for exact head 3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5.

Ticket: ticket-103
Correlation ID: ticket-103-repeated-adoption-20260910
Model: openrouter/z-ai/glm-5.3-flash
Package advisory authority: ADVISORY (promotion FORBIDDEN)
Package digest: 30d34c9de7e8e7e8140d44b40bf155591e7c2b3b7819da8299cbf2c1b3d9c719
Package evidence digest: 01f9c0f9e3da1c26b84d2337515a1e44e6a50f70ad8ed5d534293cbbb9efebc1
Package files: 4; high-risk samples: .governance/governance_check.py, .governance/manifest.json
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Consistent standard adoption of wellmanifest/new-project 0.20.22 at immutable revision dc2240c2 across ci.yml, manifest.base.json, manifest.json, manifest.lock.json, package.json, and pyproject.toml. The governance_check.py change resolves validation base handling for repeated adoptions conservatively (single shared target branch, ambiguous multi-delivery returns None rather than guessing). New ticket-103 intent and README are scoped with allowedPaths covering exactly the changed files. All three required checks (verify, Java adapter, koru / code-review) report PASS.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Semantic review prerequisite: satisfied; policy 676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7.

Actual PR impact radar

Exact range: 78b1e854be01e12c80dd529cb08213cdf81ad064...3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5
Change digest: 86a11864b804370fc83fd6454e20d11e8d8ef5182fd15747a81965eaac14fd91
Score: 68/100 (L), estimated 79 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":144,"base_sha":"78b1e854be01e12c80dd529cb08213cdf81ad064","binary_files":0,"categories":{"code":1,"configuration":7,"docs":1},"change_digest":"86a11864b804370fc83fd6454e20d11e8d8ef5182fd15747a81965eaac14fd91","comparison":"78b1e854be01e12c80dd529cb08213cdf81ad064...3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5","deletions":17,"file_count":9,"files":["github/workflows/ci.yml","governance/governance_check.py","governance/manifest.base.json","governance/manifest.json","governance/manifest.lock.json","package.json","project/ticket-103/README.md","project/ticket-103/intent.json","pyproject.toml"],"head_sha":"3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":5,"delivery":3,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":79,"within_budget":false},"impact":{"components":["github","governance","project","repository-root","wellmanifest"],"files":["github/workflows/ci.yml","governance/governance_check.py","governance/manifest.base.json","governance/manifest.json","governance/manifest.lock.json","package.json","project/ticket-103/README.md","project/ticket-103/intent.json","pyproject.toml","wellmanifest/new-project"],"public_interfaces":[],"runtime_dependencies":1},"schema":"subactor.ticket-radar/v1","score":68,"split":{"parts":[{"estimated_minutes":14,"name":"Implement github","scope":["github"]},{"estimated_minutes":14,"name":"Implement governance","scope":["governance"]},{"estimated_minutes":14,"name":"Implement project","scope":["project"]},{"estimated_minutes":14,"name":"Implement repository-root","scope":["repository-root"]},{"estimated_minutes":14,"name":"Implement wellmanifest","scope":["wellmanifest"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-103"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-103: [ticket-103] Fix repeated published adoption validation</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 105,51 79,85 59,71 39,56" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 79m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-103-2688
TICKET ticket-103
HEAD_SHA 3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5
CORRELATION_ID ticket-103-repeated-adoption-20260910
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT advisory_package_receipt = {"binding":{"repository":"autogrammar/todo2code","pull_request":124,"base_branch":"main","base_sha":"78b1e854be01e12c80dd529cb08213cdf81ad064","head_sha":"3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5","policy_digest":"99ca0b04bbf9c31da3269b6c8364fd0f131125ecc56b1ca2c51c23f7d25e0859","registry_digest":"4770cd0702160f57ea28918119eb5be314aeedd87f3ae44803fe070de029be82"},"package_digest":"30d34c9de7e8e7e8140d44b40bf155591e7c2b3b7819da8299cbf2c1b3d9c719","evidence_digest":"01f9c0f9e3da1c26b84d2337515a1e44e6a50f70ad8ed5d534293cbbb9efebc1","package_file_count":4,"samples":[{"path":".governance/governance_check.py","risk":"executable,code","diff_digest":"995afdbcfaf8c61af08a82f43c021398be489d9719a26016c8d73f82706cfe69","sample_digest":"de78c717197b741c145349b7e8265f6baf5c471effa76301265f40e76608dd8c"},{"path":".governance/manifest.json","risk":"extendable","diff_digest":"0ff21e886030162bc5fa44d35b2faac63bf80cdd21948877b486a0daf48b8617","sample_digest":"0ff21e886030162bc5fa44d35b2faac63bf80cdd21948877b486a0daf48b8617"}],"authority":"ADVISORY","promotion":"FORBIDDEN"}
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["Live OpenRouter contract (opt-in)=SKIPPING","governance=SKIPPING","verify=PASS","Java adapter (JDK 17 required)=PASS","koru / code-review=PASS","governance / remote lifecycle=PASS","governance / enforce=PASS","verify=PASS","Java adapter (JDK 17 required)=PASS"]
INPUT required_checks = ["verify","Java adapter (JDK 17 required)","koru / code-review"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT semantic_review_assessment = {"schema":"subactor.validator/semantic-review-assessment/v1","subject":{"repository":"autogrammar/todo2code","pull_request":124,"head_sha":"3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5","base_sha":"78b1e854be01e12c80dd529cb08213cdf81ad064","diff_sha256":"b804da497f18b2a2fcef3fb51b8feed63c21e5e9e27bde769830cd8cf60a1b4e"},"policy":{"policy_schema":"subactor.validator/semantic-review-policy/v1","policy_version":1,"policy_sha256":"676cb4516bbfed2a000e40b9b1b6e4a430ecc761ec546aeb53d721a1905cfdd7","required":true,"critical_paths":[".github/workflows/ci.yml",".governance/governance_check.py",".governance/manifest.base.json",".governance/manifest.json",".governance/manifest.lock.json"],"observed_paths":[".github/workflows/ci.yml",".governance/governance_check.py",".governance/manifest.base.json",".governance/manifest.json",".governance/manifest.lock.json","package.json","project/ticket-103/README.md","project/ticket-103/intent.json","pyproject.toml"]},"grounding":"full-diff-not-per-finding-proof","execution_authority":false,"status":"satisfied","reason":null,"review_sha256":"e56739cfeb3a25a59342b008d8a765594ec23818c31b58abe62ba497dd2dd134","unresolved":[]}
INPUT superseded_checks = []
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"78b1e854be01e12c80dd529cb08213cdf81ad064","head_sha":"3f3f56ea47e5b7ebe5fdb83d032adf031db9f3c5","change_digest":"86a11864b804370fc83fd6454e20d11e8d8ef5182fd15747a81965eaac14fd91","score":68,"complexity":"L","estimated_minutes":79,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "openrouter/z-ai/glm-5.3-flash"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 1c82ce8 into main Sep 10, 2026
15 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket/103-repeated-adoption-validation branch September 10, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant