refactor(authup)!: rename admin UI to client-admin-console (values: ui -> adminConsole) - #3
refactor(authup)!: rename admin UI to client-admin-console (values: ui -> adminConsole)#3tada5hi wants to merge 3 commits into
Conversation
authup/authup#3370 renames the admin UI app: the docker entrypoint selector changes from client/web to client/console. The ui deployment args and every doc/comment reference follow. The server:/ui: values keys are unchanged (operator-facing vocabulary). Must ship together with the appVersion bump to the first authup release that contains the rename; the beta.58 image only knows client/web.
📝 WalkthroughWalkthroughThe chart renames the admin UI from ChangesAdmin Console Rename
Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR updates the Authup Helm chart to follow the upstream admin UI rename from client-web to client-console, including the UI container entrypoint args and the chart’s documentation surfaces.
Changes:
- Update the UI Deployment default container args from
client/web starttoclient/console start. - Rename documentation references across the repo (root README, chart README, design record, NOTES, agent/reference docs) to “client-console”.
- Adjust values documentation section headings/comments to reflect “client-console” while keeping operator-facing keys (
ui:) unchanged.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates root repo highlights/chart listing wording to “client-console”. |
| DESIGN.md | Updates design record terminology and the documented UI args to client/console. |
| charts/authup/values.yaml | Updates values doc comments/section header to “client-console”. |
| charts/authup/templates/ui/deployment.yaml | Switches default UI container args to client/console start. |
| charts/authup/templates/NOTES.txt | Updates post-install notes to label the UI as “client-console”. |
| charts/authup/templates/_ui-env.tpl | Updates UI env helper comments to “client-console”. |
| charts/authup/README.md | Updates generated chart README content to “client-console”. |
| charts/authup/Chart.yaml | Updates chart description wording to “client-console”. |
| AGENTS.md | Updates repo agent guide wording to “client-console”. |
| .agents/structure.md | Updates structure doc wording to “client-console”. |
| .agents/references/authup.md | Updates upstream reference mappings/paths for “client-console”. |
| .agents/architecture.md | Updates architecture doc wording to “client-console”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| args: | ||
| - client/web | ||
| - client/console | ||
| - start | ||
| {{- end }} |
| password recovery). This is the identity origin. | ||
| - **client-web** — the Nuxt-based admin UI, an ordinary OAuth2 relying party | ||
| - **client-console** — the Nuxt-based admin UI, an ordinary OAuth2 relying party | ||
| (optional; disable with `ui.enabled=false` for a headless IdP). | ||
| - optionally, single-instance **PostgreSQL**, **MySQL** or **Valkey** built-in | ||
| instances on docker-official images — a convenience for dev and small |
| @@ -406,7 +406,7 @@ server: | |||
| # origin can obtain full-permission tokens via the per-realm web client. | |||
| # List or comma-separated string; tpl-rendered. | |||
| trustedOrigins: [] | |||
| # -- Automatically append the client-web UI origin to TRUSTED_ORIGINS (removes the | |||
| # -- Automatically append the client-console UI origin to TRUSTED_ORIGINS (removes the | |||
| # most common dead-login misconfiguration) | |||
| trustedOriginsAppendUI: true | |||
…hema The lint job regenerates README.md and values.schema.json; the README.md.gotmpl source and the generated schema still carried client-web, so the drift check re-introduced it.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/references/authup.md:
- Line 12: Keep all Authup references compatible with the pinned appVersion
"1.0.0-beta.58" by replacing unsupported client/console and apps/client-console
references with the documented client/web equivalents. Update
.agents/references/authup.md lines 12 and 42-46, .agents/structure.md lines
60-67, and DESIGN.md lines 26 and 103-105; keep deployment arguments and
documentation aligned with the pinned image.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 799cdfb1-7832-4487-816b-1857f8a99730
📒 Files selected for processing (14)
.agents/architecture.md.agents/references/authup.md.agents/structure.mdAGENTS.mdDESIGN.mdREADME.mdcharts/authup/Chart.yamlcharts/authup/README.mdcharts/authup/README.md.gotmplcharts/authup/templates/NOTES.txtcharts/authup/templates/_ui-env.tplcharts/authup/templates/ui/deployment.yamlcharts/authup/values.schema.jsoncharts/authup/values.yaml
…minConsole values) Follows the amended upstream rename (authup/authup#3370, merged): the app is client-admin-console and the docker selector client/admin-console. Values section ui.* renames to adminConsole.*, and server.trustedOriginsAppendUI to server.trustedOriginsAppendAdminConsole. Template dir templates/ui/ becomes templates/admin-console/, helper names and the component label follow, and rendered resource names change suffix -ui to -admin-console. Value migrations recorded in BREAKING.md (0.2.0). Ship together with the appVersion bump to the first authup release containing the rename; older images only know client/web.
tada5hi
changed the title
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
charts/authup/templates/NOTES.txt (1)
4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueOptional: rename
$uiUrland the user-facing "the UI" text.Line 4 still binds the admin console URL to
$uiUrl. Line 68 still calls the component "the UI" in output that users read. Both are cosmetic, but they keep the old term visible after the rename.♻️ Proposed wording alignment
-{{- $uiUrl := include "authup.adminConsole.publicUrl" . }} +{{- $adminConsoleUrl := include "authup.adminConsole.publicUrl" . }}-WARNING: the UI has no resolvable public URL (adminConsole.publicUrl / adminConsole.ingress). Its -origin cannot be appended to TRUSTED_ORIGINS, and logins from the UI will fail +WARNING: the admin console has no resolvable public URL (adminConsole.publicUrl / +adminConsole.ingress). Its origin cannot be appended to TRUSTED_ORIGINS, and logins will fail after the OAuth2 redirect. Set adminConsole.ingress.hostname or adminConsole.publicUrl.Update the other
$uiUrluses at Lines 31 and 66 when you rename the variable.Also applies to: 66-70
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/authup/templates/NOTES.txt` at line 4, Rename the `$uiUrl` variable and all its references in the NOTES template, including the uses near the documented lines, to consistently refer to the admin console; also replace the user-facing “the UI” wording near the output section with the new admin-console terminology.charts/authup/templates/validations.yaml (1)
64-68: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueNote: the documented tripwire pattern cannot cover this rename.
The comment block asks for a fail-fast guard when a value moves.
values.schema.jsonsetsadditionalProperties: falseon the root and onserver, souiandserver.trustedOriginsAppendUIare rejected by schema validation before templates render. A.Values.uiguard here would be dead code, and users see a generic schema error instead of a migration hint. Confirm thatcharts/authup/BREAKING.mdis the only migration signal you want for this rename, or extend the comment block to state that schema-rejected keys are documented inBREAKING.mdinstead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/authup/templates/validations.yaml` around lines 64 - 68, Update the deprecation tripwire comment to state that schema-rejected legacy keys cannot be guarded during template rendering and must instead be documented in charts/authup/BREAKING.md, including the ui to server.trustedOriginsAppendUI rename. Do not add a dead .Values.ui guard.charts/authup/values.yaml (1)
763-767: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueResidual "UI" terminology after the
adminConsolerename. The rename changed keys, directories, and resource names, but the descriptive term "UI" remains in value comments and in installation output. The value comments also generatevalues.schema.jsonandREADME.md, so the old term persists in generated docs.
charts/authup/values.yaml#L763-L767: replace "UI" with "admin console" in theadminConsolevalue comments, including Lines 765, 767, 784, 851, 955, 957, 983, 995, 1003, and 1014, then runmake docs schema.charts/authup/templates/NOTES.txt#L4-L70: rename the$uiUrlvariable to$adminConsoleUrlat Lines 4, 31, and 66, and change "the UI" to "the admin console" in the warning text at Line 68.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@charts/authup/values.yaml` around lines 763 - 767, Replace all residual “UI” terminology in the adminConsole value comments in charts/authup/values.yaml at lines 763-767, 784, 851, 955, 957, 983, 995, 1003, and 1014 with “admin console,” then run make docs schema to regenerate documentation. In charts/authup/templates/NOTES.txt lines 4-70, rename $uiUrl to $adminConsoleUrl at lines 4, 31, and 66, and change “the UI” to “the admin console” in the warning text at line 68.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@charts/authup/BREAKING.md`:
- Around line 19-23: Update the authup chart’s appVersion in Chart.yaml to the
first release containing the client/admin-console start and per-realm OAuth2
client changes from authup/authup#3370 and `#3371`, then regenerate the chart
README using make docs so the documented version stays synchronized.
In `@charts/authup/README.md`:
- Around line 11-17: Regenerate charts/authup/README.md from its source rather
than editing the generated file directly. Update the relevant descriptions in
values.yaml or README.md.gotmpl, then run make docs to synchronize the README
and satisfy the documentation drift check.
In `@charts/authup/templates/admin-console/deployment.yaml`:
- Line 67: Update the container name in the deployment’s container definition
from ui to admin-console, keeping the surrounding deployment configuration
unchanged.
---
Nitpick comments:
In `@charts/authup/templates/NOTES.txt`:
- Line 4: Rename the `$uiUrl` variable and all its references in the NOTES
template, including the uses near the documented lines, to consistently refer to
the admin console; also replace the user-facing “the UI” wording near the output
section with the new admin-console terminology.
In `@charts/authup/templates/validations.yaml`:
- Around line 64-68: Update the deprecation tripwire comment to state that
schema-rejected legacy keys cannot be guarded during template rendering and must
instead be documented in charts/authup/BREAKING.md, including the ui to
server.trustedOriginsAppendUI rename. Do not add a dead .Values.ui guard.
In `@charts/authup/values.yaml`:
- Around line 763-767: Replace all residual “UI” terminology in the adminConsole
value comments in charts/authup/values.yaml at lines 763-767, 784, 851, 955,
957, 983, 995, 1003, and 1014 with “admin console,” then run make docs schema to
regenerate documentation. In charts/authup/templates/NOTES.txt lines 4-70,
rename $uiUrl to $adminConsoleUrl at lines 4, 31, and 66, and change “the UI” to
“the admin console” in the warning text at line 68.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: f6f59bf0-e05a-41c3-99a3-4d576f52e538
📒 Files selected for processing (39)
.agents/architecture.md.agents/references/authup.md.agents/references/goauthentik-helm.md.agents/structure.md.agents/testing.mdAGENTS.mdDESIGN.mdREADME.mdcharts/authup/BREAKING.mdcharts/authup/Chart.yamlcharts/authup/README.mdcharts/authup/README.md.gotmplcharts/authup/ci/default-values.yamlcharts/authup/ci/external-db-values.yamlcharts/authup/ci/mysql-values.yamlcharts/authup/ci/server-only-values.yamlcharts/authup/ci/valkey-values.yamlcharts/authup/templates/NOTES.txtcharts/authup/templates/_admin-console-env.tplcharts/authup/templates/_helpers.tplcharts/authup/templates/_urls.tplcharts/authup/templates/admin-console/configmap-env.yamlcharts/authup/templates/admin-console/deployment.yamlcharts/authup/templates/admin-console/hpa.yamlcharts/authup/templates/admin-console/httproute.yamlcharts/authup/templates/admin-console/ingress.yamlcharts/authup/templates/admin-console/networkpolicy.yamlcharts/authup/templates/admin-console/pdb.yamlcharts/authup/templates/admin-console/service.yamlcharts/authup/templates/server/networkpolicy.yamlcharts/authup/templates/ui/deployment.yamlcharts/authup/templates/ui/hpa.yamlcharts/authup/templates/ui/httproute.yamlcharts/authup/templates/ui/ingress.yamlcharts/authup/templates/ui/pdb.yamlcharts/authup/templates/ui/service.yamlcharts/authup/templates/validations.yamlcharts/authup/values.schema.jsoncharts/authup/values.yaml
💤 Files with no reviewable changes (6)
- charts/authup/templates/ui/ingress.yaml
- charts/authup/templates/ui/httproute.yaml
- charts/authup/templates/ui/hpa.yaml
- charts/authup/templates/ui/pdb.yaml
- charts/authup/templates/ui/deployment.yaml
- charts/authup/templates/ui/service.yaml
🚧 Files skipped from review as they are similar to previous changes (8)
- AGENTS.md
- charts/authup/Chart.yaml
- charts/authup/README.md.gotmpl
- .agents/structure.md
- README.md
- .agents/architecture.md
- DESIGN.md
- .agents/references/authup.md
| - The admin UI container now starts with `client/admin-console start` and | ||
| logs in against the per-realm `admin-console` OAuth2 client. Requires an | ||
| authup image containing authup/authup#3370 + #3371; older images only know | ||
| `client/web` and would crash-loop. Ship this chart version together with | ||
| the `appVersion` bump to that release. |
There was a problem hiding this comment.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
🧩 Analysis chain
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
rg -n '^(version|appVersion):' charts/authup/Chart.yaml
rg -n 'AppVersion:|client/admin-console|client/web' \
charts/authup/README.md \
charts/authup/templates/admin-console/deployment.yamlRepository: authup/helm
Length of output: 625
🌐 Web query:
authup/authup #3370 client/admin-console start
💡 Result:
The query authup/authup #3370 does not correspond to a known issue or public discussion related to a client/admin-console start error in the Authup repository [1][2]. Based on the repository's activity, recent relevant PRs and issues (such as #3182 and #3313) have focused on accessibility and database relation handling [3][4][5]. To start the Authup Admin Console (client-web) and Server (server-core), use the following methods: 1. Using the Global CLI: You can start the Authup ecosystem using the npx command [6]: npx authup@latest start 2. Using Docker: Run the client and server components separately via Docker [7][6]: # Start Server docker run -d --name authup-server -p 3001:3000 authup/authup:latest server/core start # Start Client (Admin Console) docker run -d --name authup-client -p 3000:3000 -e NUXT_PUBLIC_API_URL=http://localhost:3001 authup/authup:latest client/web start 3. Development Environment: If you are working within the Authup repository, you can start the components using npm workspaces [6]: # In separate terminals: npm run cli-dev --workspace=apps/server-core -- start npm run dev --workspace=apps/client-web Ensure the NUXT_PUBLIC_API_URL environment variable is correctly pointed to your backend server instance when running the client-web application [7].
Citations:
- 1: https://github.com/authup/authup
- 2: build(deps-dev): bump the minorandpatch group with 20 updates authup#3169
- 3: fix: accessible names for icon-only action buttons on entity index pages authup#3182
- 4: fix: accessible names for icon-only action buttons on entity index pages authup#3182
- 5: server-core: Node creation crashes — clientPermission.permission undefined after authup beta.54 relations read gate PrivateAIM/hub#1777
- 6: https://npm.io/package/@authup/client-web-nuxt
- 7: https://authup.org/
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
echo "Charts files:"
git ls-files charts/authup | sed -n '1,120p'
echo
echo "Chart.yaml:"
cat -n charts/authup/Chart.yaml
echo
echo "Package metadata references:"
rg -n '"version"|"appVersion"|authup/authup|authup/admin-console|admin-console|client/admin-console' --glob '!**/node_modules/**' --glob '!**/.git/**' .Repository: authup/helm
Length of output: 10975
🏁 Script executed:
#!/usr/bin/env bash
set -euo pipefail
python3 - <<'PY'
try:
import urllib.request, urllib.error
from urllib.parse import urlencode, urljoin
base = "https://api.github.com/repos/authup/authup"
refs = "/git/refsof/tags/"
candidates = [
"1.0.0-beta.58",
"1.0.0-beta.59",
"1.0.0",
"1.0.1",
"1.0.2",
"1.1.0",
]
for tag in candidates:
url = base + refs + urllib.parse.quote(tag)
try:
with urllib.request.urlopen(url, timeout=15) as r:
print(f"{tag}: ok status={r.status}")
except urllib.error.HTTPError as e:
print(f"{tag}: api error status={e.code}")
except Exception as exc:
print(f"git API probe failed: {exc}")
PY
echo
echo "Chart breaking context:"
sed -n '1,35p' charts/authup/BREAKING.md | cat -nRepository: authup/helm
Length of output: 1652
🌐 Web query:
authup 1.0.0-beta.58 client/admin-console admin-console OAuth2
💡 Result:
Authup is an open-source identity and access management system that provides OAuth2 and OpenID Connect (OIDC) capabilities [1]. The system uses a modular, multi-tenant architecture where entities are organized into realms [1][2]. Regarding your query: 1. Versioning: As of August 2, 2026, the latest major release branch is in the v1.0.0-beta.x series [3]. Development releases, such as v1.0.0-beta.51, are active as of July 2026 [3][4]. While specific beta versions like 1.0.0-beta.58 may exist in the release history or development cycle, documentation and repository activity consistently reference the 1.0.0-beta series [3][4]. 2. Admin Console: Authup includes a web-based administration console (often referred to as client-web or the admin UI) [1][2]. This console interacts with the core Authup REST API to manage realms, users, roles, permissions, and OAuth2 clients [1][2]. 3. OAuth2 Integration: - Built-in Client: Every Authup realm automatically contains a built-in, public OAuth2 client named web [5]. This is the client the web UI uses to handle user logins via the authorization-code flow with PKCE [5]. - Client Configuration: Within the admin console, you can configure custom OAuth2 clients with various authentication methods, such as shared secrets or TLS certificates (mTLS) [6][7][5]. - Declarative Provisioning: Authup supports declarative provisioning, which allows you to define the initial state of clients and their configurations as part of your deployment setup [5]. For technical details on managing OAuth2 clients, configuring trust anchors (Trusted CAs) for TLS authentication, or upgrading between beta versions, please refer to the official Authup documentation [8][6][7].
Citations:
- 1: https://authup.org/
- 2: https://authup.org/getting-started/
- 3: https://github.com/authup/authup
- 4: chore: release master authup#3180
- 5: https://authup.org/guide/deployment/provisioning.html
- 6: https://authup.org/guide/user/client-certificates.html
- 7: https://authup.org/guide/user/trust-anchors.html
- 8: https://authup.org/guide/deployment/upgrading.html
🌐 Web query:
github authup authup release v1.0.0-beta.58 client admin console OAuth2
💡 Result:
Authup is an open-source authentication and authorization framework designed for OAuth2 and OpenID Connect (OIDC) identity management [1][2]. It features a modular, multi-realm architecture that allows for scaling specific components like the REST API and the administrative user interface independently [2][3]. Regarding your query about release v1.0.0-beta.58, as of August 2, 2026, the latest identified release version on the primary repository is v1.0.0-beta.51 [1]. The project maintains an active development cycle on GitHub, using automated release processes to manage versioning [4]. Key features of the Authup admin console and its OAuth2 implementation include: Admin Console: The system provides a web-based administrative UI designed to manage users, permissions, and OAuth2 clients [2][3]. This interface interacts directly with the Authup REST API [3]. OAuth2 Configuration: The admin console allows administrators to configure various OAuth2 client properties, including: - Authentication Methods: Options include None, Shared Secret, and TLS Certificate [5]. - Token Binding: Supports TLS-based token binding to enhance security [5][6]. - Client Management: Administrators can define trust anchors (trusted CAs) for mTLS client authentication directly through the UI in their respective realms [6]. If you are currently deploying or upgrading Authup, you should consult the official upgrade guide to identify any breaking changes or required operator actions associated with newer beta releases, as these are tracked by version [7]. You can monitor the official GitHub repository for the most current release metadata as development progresses beyond v1.0.0-beta.51 [1].
Citations:
- 1: https://github.com/authup/authup
- 2: https://authup.org/
- 3: https://authup.org/getting-started/
- 4: https://github.com/authup/authup/blob/7e43cabf3a3455f105073389749429f3919e4579/.github/workflows/release.yml
- 5: https://authup.org/guide/user/client-certificates.html
- 6: https://authup.org/guide/user/trust-anchors.html
- 7: https://authup.org/guide/deployment/upgrading.html
Update appVersion to the first release containing the admin-console start/OAuth2 client migration.
charts/authup/Chart.yaml still points at 1.0.0-beta.58, while the workload now uses client/admin-console start. If 1.0.0-beta.58 does not include authup/authup#3370 and #3371, older images can crash-loop; bump appVersion accordingly and regenerate charts/authup/README.md with make docs.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/authup/BREAKING.md` around lines 19 - 23, Update the authup chart’s
appVersion in Chart.yaml to the first release containing the
client/admin-console start and per-realm OAuth2 client changes from
authup/authup#3370 and `#3371`, then regenerate the chart README using make docs
so the documented version stays synchronized.
Source: Coding guidelines
| Authup is an authentication & authorization system. This chart deploys the server-core IdP/API service and the client-admin-console admin UI, with optional built-in PostgreSQL, MySQL and Valkey instances. It deploys: | ||
|
|
||
| - **server-core** — the Authup IdP/API service: the OAuth2/OIDC protocol | ||
| surface plus the server-rendered auth pages (login, consent, registration, | ||
| password recovery). This is the identity origin. | ||
| - **client-web** — the Nuxt-based admin UI, an ordinary OAuth2 relying party | ||
| (optional; disable with `ui.enabled=false` for a headless IdP). | ||
| - **client-admin-console** — the Nuxt-based admin UI, an ordinary OAuth2 relying party | ||
| (optional; disable with `adminConsole.enabled=false` for a headless IdP). |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Regenerate this generated file from its source files.
Do not edit charts/authup/README.md directly. Update the descriptions in charts/authup/values.yaml or charts/authup/README.md.gotmpl, then run make docs. This keeps the generated documentation synchronized and satisfies the CI drift gate described in .agents/testing.md.
As per coding guidelines, never edit charts/authup/README.md directly; update values.yaml comments or README.md.gotmpl, then run make docs.
Also applies to: 114-209, 412-412, 421-421
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/authup/README.md` around lines 11 - 17, Regenerate
charts/authup/README.md from its source rather than editing the generated file
directly. Update the relevant descriptions in values.yaml or README.md.gotmpl,
then run make docs to synchronize the README and satisfy the documentation drift
check.
Source: Coding guidelines
| initContainers: {{- include "authup.tplvalues.render" (dict "value" .Values.adminConsole.initContainers "context" $) | nindent 8 }} | ||
| {{- end }} | ||
| containers: | ||
| - name: ui |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Rename the container to match the admin-console component.
The container is still named ui while every other identifier in this file (fullname, labels, matchLabels, ConfigMap name) uses "admin-console". Update the container name for consistency with the rest of the rename.
🏷️ Proposed fix
containers:
- - name: ui
+ - name: admin-console📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: ui | |
| - name: admin-console |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@charts/authup/templates/admin-console/deployment.yaml` at line 67, Update the
container name in the deployment’s container definition from ui to
admin-console, keeping the surrounding deployment configuration unchanged.
What
Follows the upstream renames — authup/authup#3370 (app
client-admin-console, docker selectorclient/admin-console) and authup/authup#3371 (per-realmadmin-consoleOAuth2 client):templates/admin-console/deployment.yamlcontainer argsclient/web start->client/admin-console start.BREAKING.mdfor 0.2.0): sectionui.*->adminConsole.*(every key moves unchanged);server.trustedOriginsAppendUI->server.trustedOriginsAppendAdminConsole.-ui->-admin-console(Deployment/Service/Ingress/... re-created on upgrade), component labelui->admin-console, template dirtemplates/ui/->templates/admin-console/, helper names follow..agents/docs.server:values key (operator vocabulary; the server app keeps its name).Merge coupling
Do not merge while
appVersiontargets1.0.0-beta.58: that image only knowsclient/web, so the renamed args would crash-loop the admin-console deployment. Merge together with theappVersionbump to the first authup release containing authup/authup#3370 + #3371, as chart 0.2.0 (breaking values).Verification
helm lintgreen;helm templaterenders both the default and server-only value sets; args render asclient/admin-console startand resources as<release>-authup-admin-console.Summary by CodeRabbit
Breaking Changes
ui.*toadminConsole.*.server.trustedOriginsAppendAdminConsole.Improvements