Skip to content

feat(lighting): consolidate magic lantern illumination - #203

Draft
zoeyrose wants to merge 3 commits into
mainfrom
feat/89-magic-lantern-illumination-main
Draft

feat(lighting): consolidate magic lantern illumination#203
zoeyrose wants to merge 3 commits into
mainfrom
feat/89-magic-lantern-illumination-main

Conversation

@zoeyrose

@zoeyrose zoeyrose commented Aug 13, 2026

Copy link
Copy Markdown
Member

Summary

  • give all 402 visible magic lanterns warm-gold fixture-owned illumination across 66 maps
  • preserve the established heterogeneous radius-3/4/5/6/7/9 compositions while removing 239 co-located neutral helper sources
  • collapse five duplicate direct-plus-helper compositions and deliberately illuminate the 101 previously source-less fixtures through reviewed form defaults
  • add a fail-closed semantic fixture contract covering exact archetypes, placements, maps, radii, color, contextual checks, and resolved source digests

Closes #89.

Coordinates

  • Base: main@94eb4d16f7cd46dd4b9a749214e5ae33198b3679
  • Head branch: feat/89-magic-lantern-illumination-main
  • Initial head: 5263153365f4a4e702c2b23c50e5e983f06b0bc4
  • Current head: c6fbf5d7a7eec022c0a9a4f4dbc006aae62a48ae
  • Worktree: /workspaces/atrinik/workspace/worktrees/content/issue-89-magic-lantern-main
  • Feature commits: 526315336 feat(lighting): consolidate magic lantern illumination; 3580a3a8e docs(lighting): clarify review provenance
  • Synchronization: c6fbf5d7a merges current main, retaining the newly landed lava fixture contract alongside this change

Authored behavior

  • lantern_magic.131 inherits radius 5; lantern2_magic.131 inherits radius 7; both retain ffd080.
  • All 239 neutral light3light9 helpers are removed from the exact co-located fixtures. A total of 190 map-local radii preserve non-default footprints, 44 transfers match the new defaults, and five existing direct radius-7 sources remain while their duplicate helpers are removed.
  • The final distribution is 2 × radius 3, 10 × radius 4, 160 × radius 5, 32 × radius 6, 179 × radius 7, and 19 × radius 9.
  • Directions, animations, coordinates, obstruction, exits/tile links, darkness/time behavior, names, plural names, and every unrelated gameplay field remain unchanged.
  • Everlink receives fixture ownership only; localized palette choices remain owned by feat(maps): add localized lantern and garden colors across Everlink #83.

Validation

  • python3 tools/validate.py — passed at c6fbf5d7a: 164 tests plus lossless validation of 1,355 archetypes/3,651 maps, semantic lighting, schema, 8,105-definition/68,496-reference catalog, contracts, syntax prototypes, resource collection, and isolated runtime collection
  • python3 tools/world_content_audit.py lights --check — passed at c6fbf5d7a: 123 archetypes, 10 artifacts, 11,787 instances across 639 maps; 6,706 explicit colors, 5,214 intentional neutral, zero unreviewed
  • 47 focused world-audit, syntax-evaluation, and content-catalog tests — passed
  • focused fixture reconstruction — 402/402 visible ffd080 emitters across 66 maps, exact final radius distribution, zero non-emitters, zero same-tile helper emitters
  • transaction audit — all 46 map results match the digest-bound atomic migration output; exactly 239 helpers removed and 190 local radii inserted
  • git diff --check — passed
  • hosted Content validation, conventional metadata, Ubuntu/Windows syntax, CodeQL, and Actions analysis checks — passed at c6fbf5d7a

Independent review

Two initial fresh-context whole-diff reviewers independently reconstructed all 402 placements, confirmed zero non-light field/object/coordinate/nesting changes, and found no migration defect. Both identified the same provenance/runtime gap: historical PR #67 was described too broadly and exact-head smooth/discrete Classic verification was still pending. Commit 3580a3a8e distinguishes the historical palette/source baseline from current fixture decisions. A synchronized-head fresh review confirms the magic-lantern/candle/lava ledger reconciliation and all six hosted checks, with exact-head Classic verification remaining as the sole actionable gate.

Runtime boundary and remaining draft gates

The authored main line is the sole mutable content source. Replacement integration remains unavailable under atrinik/atrinik#266, atrinik/atrinik#269, and atrinik/atrinik#270, so this PR does not claim replacement runtime rendering. Deterministic Classic target verification and a fresh post-fix whole-diff review remain pending while the PR is draft.

Optional renderer diagnostics remain ignored under build/ and are not committed or treated as release artifacts.

@zoeyrose zoeyrose moved this to Review in Atrinik work Aug 13, 2026
…-illumination-main

# Conflicts:
#	maps/light-source-review.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review

Development

Successfully merging this pull request may close these issues.

feat(lighting): consolidate magic-lantern illumination onto visible fixtures

1 participant