feat(lighting): consolidate magic lantern illumination - #203
Draft
zoeyrose wants to merge 3 commits into
Draft
Conversation
…-illumination-main # Conflicts: # maps/light-source-review.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #89.
Coordinates
main@94eb4d16f7cd46dd4b9a749214e5ae33198b3679feat/89-magic-lantern-illumination-main5263153365f4a4e702c2b23c50e5e983f06b0bc4c6fbf5d7a7eec022c0a9a4f4dbc006aae62a48ae/workspaces/atrinik/workspace/worktrees/content/issue-89-magic-lantern-main526315336 feat(lighting): consolidate magic lantern illumination;3580a3a8e docs(lighting): clarify review provenancec6fbf5d7amerges currentmain, retaining the newly landed lava fixture contract alongside this changeAuthored behavior
lantern_magic.131inherits radius 5;lantern2_magic.131inherits radius 7; both retainffd080.light3–light9helpers are removed from the exact co-located fixtures. A total of 190 map-local radii preserve non-default footprints, 44 transfers match the new defaults, and five existing direct radius-7 sources remain while their duplicate helpers are removed.Validation
python3 tools/validate.py— passed atc6fbf5d7a: 164 tests plus lossless validation of 1,355 archetypes/3,651 maps, semantic lighting, schema, 8,105-definition/68,496-reference catalog, contracts, syntax prototypes, resource collection, and isolated runtime collectionpython3 tools/world_content_audit.py lights --check— passed atc6fbf5d7a: 123 archetypes, 10 artifacts, 11,787 instances across 639 maps; 6,706 explicit colors, 5,214 intentional neutral, zero unreviewedffd080emitters across 66 maps, exact final radius distribution, zero non-emitters, zero same-tile helper emittersgit diff --check— passedContent validation, conventional metadata, Ubuntu/Windows syntax, CodeQL, and Actions analysis checks — passed atc6fbf5d7aIndependent review
Two initial fresh-context whole-diff reviewers independently reconstructed all 402 placements, confirmed zero non-light field/object/coordinate/nesting changes, and found no migration defect. Both identified the same provenance/runtime gap: historical PR #67 was described too broadly and exact-head smooth/discrete Classic verification was still pending. Commit
3580a3a8edistinguishes the historical palette/source baseline from current fixture decisions. A synchronized-head fresh review confirms the magic-lantern/candle/lava ledger reconciliation and all six hosted checks, with exact-head Classic verification remaining as the sole actionable gate.Runtime boundary and remaining draft gates
The authored
mainline is the sole mutable content source. Replacement integration remains unavailable under atrinik/atrinik#266, atrinik/atrinik#269, and atrinik/atrinik#270, so this PR does not claim replacement runtime rendering. Deterministic Classic target verification and a fresh post-fix whole-diff review remain pending while the PR is draft.Optional renderer diagnostics remain ignored under
build/and are not committed or treated as release artifacts.