Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Use .css instead of .scss in property lists - #180

Open
winstliu wants to merge 2 commits into
masterfrom
wl-use-css-in-property-list
Open

Use .css instead of .scss in property lists#180
winstliu wants to merge 2 commits into
masterfrom
wl-use-css-in-property-list

Conversation

@winstliu

Copy link
Copy Markdown
Contributor

This change brings language-sass in line with language-css and language-less. The main goal of this PR is to allow for deduplication in autocomplete-css.

@winstliu

winstliu commented Oct 9, 2016

Copy link
Copy Markdown
Contributor Author

/cc @esdoppio for language review, @simurai for styling. There shouldn't be anything explicitly targeting the .scss variant, right?

@hediyi

hediyi commented Oct 9, 2016

Copy link
Copy Markdown
Contributor

Theoretically, I think "meta.property-list.scss" should remain as it is, because unlike property-name or property-value, what can go into a "property list" (still don't like the name) of SCSS is very different from that of CSS. But other than that, I don't see why we can't change it.

@simurai simurai left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with this.

I don't think themes want style properties differently in SCSS vs CSS. And I think they still can with a more specific selector, like .source.scss xxx.css.

@winstliu

Copy link
Copy Markdown
Contributor Author

Alternatively, we could use meta.property-list.css.scss. Any thoughts about that?

@simurai

simurai commented Oct 11, 2016

Copy link
Copy Markdown

Yeah, I guess having both (.css.scss) would lower the chance of breaking anything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants