Add healthcheck for Oracle testing - #1305
Draft
DarkSide666 wants to merge 3 commits into
Draft
Conversation
mvorisek
reviewed
Aug 17, 2026
| image: gvenzl/${{ matrix.type == 'Phpunit Lowest' && 'oracle-free:slim-faststart' || 'oracle-xe:18-slim-faststart' }} | ||
| env: | ||
| ORACLE_PASSWORD: atk4_pass | ||
| options: >- |
Member
There was a problem hiding this comment.
This change/PR increases the "Initialize containers" CI step by 30-60 seconds.
I would be happy if this healthcheck can be moved to the Oracle testing step directly as it should be alsmost for free there...
mvorisek
changed the title
mvorisek
marked this pull request as draft
August 17, 2026 09:39
Member
Author
|
Moved Oracle healthcheck from initialization phase to right before tests. |
DarkSide666
marked this pull request as ready for review
August 17, 2026 11:15
Member
|
Something like this, it is ugly ATM, I will review this PR later as not immediately needed, as the non-Oracle tests give enough time for Oracle to startup. |
mvorisek
marked this pull request as draft
August 17, 2026 11:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.