Skip to content

fix(marketplace): no bloquear uninstall por requires opcionales - #281

Merged
akromicc merged 1 commit into
mainfrom
fix/uninstall-skip-optional-requires
Aug 18, 2026
Merged

fix(marketplace): no bloquear uninstall por requires opcionales#281
akromicc merged 1 commit into
mainfrom
fix/uninstall-skip-optional-requires

Conversation

@akromicc

Copy link
Copy Markdown
Contributor

Summary

  • `compatibility.requires[].optional: true` (POS → caja) no debe impedir desinstalar Caja: POS cobra sin ese addon.
  • `extractRequires` ya no snapshottea peers opcionales; el upgrade refresca el snapshot; el 409 deduplica filas duplicadas de `marketplace_installations`.

Test plan

  • Installed POS + Caja → desinstalar Caja sin cascada (200, POS sigue).
  • Desinstalar customers con POS instalado sigue 409 (require duro).
  • Dialog de dependientes no lista POS dos veces si hay filas duplicadas.

POS declara caja como optional:true; extractRequires lo persistía como
dependencia dura y el 409 pedía desinstalar POS. Omitir peers opcionales,
refrescar el snapshot en upgrade y deduplicar filas duplicadas en el listado.
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 313ab07e-1129-460b-b415-8aea4d4f174a


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akromicc
akromicc merged commit 3062b24 into main Aug 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant