Skip to content

fix(manifest): confirm_message implica Confirm=true - #277

Merged
akromicc merged 1 commit into
mainfrom
fix/confirm-message-implies-confirm
Aug 15, 2026
Merged

fix(manifest): confirm_message implica Confirm=true#277
akromicc merged 1 commit into
mainfrom
fix/confirm-message-implies-confirm

Conversation

@akromicc

Copy link
Copy Markdown
Contributor

Summary

  • En FromV3, si hay confirm_message se deriva Confirm=true.
  • Evita que acciones wasm executable abran el dispatcher y rendericen null cuando el addon solo declaró el mensaje.

Test plan

  • go test ./manifest/ -run ConfirmMessageImpliesConfirm
  • Reinstalar addon con solo confirm_message y verificar metadata confirm: true

Addons v3 a menudo declaran solo confirm_message; el dispatcher React
gateaba en confirm y devolvía null en acciones executable.
@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 60557d61-e88e-497d-93ca-4cf2fd447042


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@akromicc
akromicc merged commit cde9dae into main Aug 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant