docs: fix stale capability table + NOT-auto claims in kernel docs - #276
Merged
Conversation
- add missing connector:read capability kind (security/context.go) to the
addon-capability table in permissions.md
- document manifest v3 rbac{} as schema-only / unenforced (no Go consumer
outside types.go) so addon authors don't build on a dead field
- correct dynamic-system.md's NOT-auto table: computed columns (formulas/
rollup) and row-status automation (stage_field/stages/transitions) are
now auto via manifest v3, not addon-handler-only as previously stated
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
permissions.md's addon-capability table was missingconnector:read(real, enforced kind insecurity/context.go, used by cross-addonconnector_getdispatch) — added.rbac{}block (manifest/v3/types.go) is schema-only: no Go code outsidetypes.goconsumesManifest.RBAC, so it's not a live permission system yet. Prevents addon authors from building on a dead field.dynamic-system.md's "What is NOT auto" table claimed computed columns needed a custom handler and said nothing about row-status automation — both are wrong/incomplete now: manifest v3formulas[]/rollupandstage_field/stages[]/transitions[]/on_transition[]make both automatic. Fixed the table and added a short pointer to the SDK's manifest-spec.md (companion PR docs: refresh addon-authoring docs (v3 manifest, real publish flow, full WASM ABI) metacore-sdk#748) for the full field reference, rather than duplicating it here.Scoped narrowly to verified factual errors/gaps in the kernel's internal docs (as opposed to addon-authoring docs, which live in metacore-sdk and were just refreshed there).
Test plan