Reuse Kafka producer singleton for /remember (#34)#54
Open
askmy-stack wants to merge 1 commit into
Open
Conversation
Avoid constructing a new confluent_kafka Producer on every request; lazy-init a process-wide singleton with double-checked locking. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
Reviewer checklist (@askmy-stack)Ready for your review — CI is green (
Fixes #34 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Producersingleton forPOST /remember(double-checked locking) so each request no longer opens a new clientCloses #34
Test plan
pytest tests/api/test_remember.py --no-cov(3 passed)POST /remembertwice under load and confirm one producer construction in logs/metricsMade with Cursor