fix: upgrade to rust-numpy 0.29, switch to cast_exact - #5
Merged
Conversation
Closes out the cast/downcast workaround from Session 4 now that PyO3/rust-numpy#550 fixed is_exact_type_of. cast_exact also rejects numpy subclasses (e.g. np.matrix), which non-exact cast did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyo30.28.3 → 0.29.0 andnumpy0.28.0 → 0.29.0casttocast_exact, now that PyO3/rust-numpy#550 fixedis_exact_type_of(shipped in 0.29.0)cast_exactadditionally rejects NumPy subclasses (e.g.np.matrix) viaPyArray_CheckExact, which non-exactcastdid notTest plan
cargo build --release— cleanmaturin develop --release && pytest -q— 38/38 passnp.matrixinput is now rejected withTypeError; plain ndarrays unaffected