fix: replace deprecated downcast with cast (PyO3 0.28 migration) - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Removes
#![allow(deprecated)]and migrates all dtype-dispatch calls fromthe deprecated
downcastto the recommendedcastAPI.Background
Filed PyO3/rust-numpy#549 to ask about the migration path. A maintainer
confirmed that
cast(non-exact) usesPyTypeInfo::is_type_ofwhich callsrust-numpy's
extractinternally — this performs the same dtype check asthe old
downcast, making it a correct drop-in replacement.Changes
#![allow(deprecated)]x.downcast::<PyArrayDyn<T>>()→x.cast::<PyArrayDyn<T>>()Verified
All 16 correctness checks pass. Dtype dispatch, error handling, and
benchmarks are identical to before.