feat: f32 support via FloatElem trait, both dtypes accept - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds float32 support to all three functions. Public API is unchanged — pass either dtype and the output matches the input automatically.
Changes
FloatElemtrait implemented by bothf32andf64relu,sigmoid,softmax) are now generic overF: FloatElemdowncastat runtime#![allow(deprecated)]suppresses PyO3 0.28 deprecation warning pending upstream fix(see PyO3/rust-numpy#)
Benchmark results (1000×1000, 200 runs, AMD x86-64)
Correctness
16/16 checks pass — 1D, 2D, 3D, both dtypes, multiple axes, error handling.