Fixes for 0.1.0rc1 - #239
Open
embray wants to merge 7 commits into
Open
Conversation
In particular, try UFFD_USER_MODE_ONLY flag even if it wasn't defined in the kernel headers (as on Conda) and refactor to better support caching the result of the probe at the process-level. This gets rid of the previous hack "warning: UFFD_USER_MODE_ONLY_MISSING" which was actually the wrong behavior for Linux 5.11+ kernels.
Just use the portable ``PRI<T>`` macros.
ci: fix this in the CI as well; will be curious to see how this impacts the macOS build (which was still compiling without MD5 support previously)
This would cause the malloc-fail tests to break since they wrap strdup by symbol name (which is replaced with __strdup if the inline versions are defined). This can be disabled in bits/string2.h by defining __NO_STRING_INLINES.
embray
added
documentation
embray
force-pushed
the
release-0.1.0-followups
branch
from
July 27, 2026 15:20
9189946 to
38bfc1d
Compare
Collaborator
Author
|
Hmm... Now that we actually are building with MD5 support on macOS this error is everywhere. Investigating.... 😞 |
Collaborator
Author
|
Ugh, confirmed: This is the same as irods/irods#2578 |
Collaborator
Author
|
Well investigating the build logs I also realized there are still some "error: Invalid UTF8 (invalid) in the input stream" coming from libfyaml; that was supposed to be fixed I thought in 2b20d02 ; this has come up a few times actually. But despite the error log the tests were still silently passing so whatever the issue is there wasn't a blocker, but it's still a bit jarring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes for various issues found while trying to build the new conda-forge recipe I added at conda-forge/staged-recipes#34323
Would have been good to test this first but that's exactly why I decided to make a release candidate first; adding an rc1 is no big deal, then I can point the conda-forge recipe to that.
One caveat: These fixes fix the conda-forge build for me locally on Linux, but I don't have any way to test it locally on macOS so hopefully no additional problems will be discovered there...
AI Disclosure
No AI tools used.