feat(execution-history): color actors by identity - #78
Merged
Conversation
Hash actorId into a stable palette so machines that share a credential class stay distinguishable in the filter rail, table, and detail drawer.
Greptile SummaryThe PR changes execution-history actor coloring from credential-kind-based tones to deterministic identity-based tones.
Confidence Score: 5/5The PR appears safe to merge, with no concrete correctness, security, build, or repository-rule issues identified. All execution-history views derive actor colors from the same persisted actorId, missing identities retain the muted presentation, and the new tests follow the package's established test configuration.
|
| Filename | Overview |
|---|---|
| packages/plugins/execution-history/src/react/status.ts | Introduces deterministic FNV-1a actor-ID hashing, an eight-slot actor palette, and a muted missing-ID fallback. |
| packages/plugins/execution-history/src/react/status.test.ts | Adds package-conventional Effect Vitest coverage for actor-tone determinism, fallback behavior, and palette selection. |
| packages/plugins/execution-history/src/react/filter-rail.tsx | Colors actor facet dots and labels using the facet's stable actorId. |
| packages/plugins/execution-history/src/react/run-row.tsx | Changes run-row actor coloring from actorKind to actorId. |
| packages/plugins/execution-history/src/react/detail-drawer.tsx | Adds an identity-colored actor dot and text treatment while preserving wrapping for long labels. |
Reviews (1): Last reviewed commit: "feat(execution-history): color actors by..." | Re-trigger Greptile
aryasaatvik
added a commit
that referenced
this pull request
Aug 23, 2026
## Summary Execution history colors actors from a hash of `actorId`, not `actorKind`. Machines that all present as `service-token` (phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer. ## Palette ```ts actorTone(run.actorId) // was actorTone(run.actorKind) → every service token painted violet ``` FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted. `actorKind` remains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette. ## Tests - `bunx --bun vitest run src/react/status.test.ts` in `@executor-js/plugin-execution-history` (determinism, muted fallback, palette membership) - `oxlint --deny-warnings` on the five owned files - Live check on executor.arya.sh needs this commit in the selfhost worktree plus a host deploy — not done here
aryasaatvik
added a commit
that referenced
this pull request
Aug 27, 2026
## Summary Execution history colors actors from a hash of `actorId`, not `actorKind`. Machines that all present as `service-token` (phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer. ## Palette ```ts actorTone(run.actorId) // was actorTone(run.actorKind) → every service token painted violet ``` FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted. `actorKind` remains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette. ## Tests - `bunx --bun vitest run src/react/status.test.ts` in `@executor-js/plugin-execution-history` (determinism, muted fallback, palette membership) - `oxlint --deny-warnings` on the five owned files - Live check on executor.arya.sh needs this commit in the selfhost worktree plus a host deploy — not done here
aryasaatvik
added a commit
that referenced
this pull request
Aug 28, 2026
## Summary Execution history colors actors from a hash of `actorId`, not `actorKind`. Machines that all present as `service-token` (phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer. ## Palette ```ts actorTone(run.actorId) // was actorTone(run.actorKind) → every service token painted violet ``` FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted. `actorKind` remains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette. ## Tests - `bunx --bun vitest run src/react/status.test.ts` in `@executor-js/plugin-execution-history` (determinism, muted fallback, palette membership) - `oxlint --deny-warnings` on the five owned files - Live check on executor.arya.sh needs this commit in the selfhost worktree plus a host deploy — not done here
aryasaatvik
added a commit
that referenced
this pull request
Aug 29, 2026
## Summary Execution history colors actors from a hash of `actorId`, not `actorKind`. Machines that all present as `service-token` (phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer. ## Palette ```ts actorTone(run.actorId) // was actorTone(run.actorKind) → every service token painted violet ``` FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted. `actorKind` remains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette. ## Tests - `bunx --bun vitest run src/react/status.test.ts` in `@executor-js/plugin-execution-history` (determinism, muted fallback, palette membership) - `oxlint --deny-warnings` on the five owned files - Live check on executor.arya.sh needs this commit in the selfhost worktree plus a host deploy — not done here
aryasaatvik
added a commit
that referenced
this pull request
Aug 29, 2026
## Summary Execution history colors actors from a hash of `actorId`, not `actorKind`. Machines that all present as `service-token` (phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer. ## Palette ```ts actorTone(run.actorId) // was actorTone(run.actorKind) → every service token painted violet ``` FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted. `actorKind` remains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette. ## Tests - `bunx --bun vitest run src/react/status.test.ts` in `@executor-js/plugin-execution-history` (determinism, muted fallback, palette membership) - `oxlint --deny-warnings` on the five owned files - Live check on executor.arya.sh needs this commit in the selfhost worktree plus a host deploy — not done here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Execution history colors actors from a hash of
actorId, notactorKind. Machines that all present asservice-token(phoenix, agni, blaze, cursor) get distinct, stable hues in the filter rail, runs table, and detail drawer.Palette
FNV-1a of the stable id indexes an 8-slot palette that avoids status (emerald/sky/amber/red) and trigger (violet/cyan/slate). Missing ids stay muted.
actorKindremains a drawer suffix, not a hue. Collisions are accepted once cardinality exceeds the palette.Tests
bunx --bun vitest run src/react/status.test.tsin@executor-js/plugin-execution-history(determinism, muted fallback, palette membership)oxlint --deny-warningson the five owned files