Skip to content

refactor: move task skill integration up the stack - #423

Merged
th3james merged 3 commits into
mainfrom
move-task-integration-up-skills-stack
Aug 19, 2026
Merged

refactor: move task skill integration up the stack#423
th3james merged 3 commits into
mainfrom
move-task-integration-up-skills-stack

Conversation

@th3james

@th3james th3james commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Changes

Moves integrations with VS Code task creature up to the imperative shell, keeps command creation as function core
https://www.destroyallsoftware.com/screencasts/catalog/functional-core-imperative-shell

  • Makes NpxSkills and TopoSkill's command creation methods return values rather than actually creating the task
  • Moves the creation and running of the task up to the action at the top of the stack
  • Reduces some of the ceremony of setting up accurate test values in tests where the implementations which consume them are mocked, because these are extra lines of code which bring zero additional verification

Screenshots

@th3james
th3james requested a review from a team as a code owner August 18, 2026 15:45
@th3james th3james changed the title refactor: Move task skill integration up the stack refactor: move task skill integration up the stack Aug 18, 2026
@github-actions github-actions Bot added the refactor Refactor change excluded from release notes label Aug 18, 2026
@th3james
th3james merged commit 49dd9db into main Aug 19, 2026
4 of 7 checks passed
@th3james
th3james deleted the move-task-integration-up-skills-stack branch August 19, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor change excluded from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants