feat!: skip updating optional or already populated required parameter values when skipped - #414
Open
awphi wants to merge 5 commits into
Open
feat!: skip updating optional or already populated required parameter values when skipped#414awphi wants to merge 5 commits into
awphi wants to merge 5 commits into
Conversation
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
# Conflicts: # docs/project-specification/02-project-configuration.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The problem
Take the following project:
I've configured my
BARparam value to a non-default. I want to now re-configure but adjust myFOOparam value. This is really annoying in Topo today because when a parameter specified adefaultand you press enter on the 'enter a value for the param' prompt, it reverts to the default! Same goes for omitting a parameter in non-interactive mode.Changes
defaultparam field altogether. It's already mostly duplication because it should be specified in the build args themselves anyway to make the projectgit clone-able.This avoids a complicated TUI (the alternative that we previously discussed) where we would have to present the user with 3 options (enter new value, use default, leave unchanged) and keeps the prompt simple:
This simpler flow has a couple of advantages:
exampleanddefaultwhich are generally duplicates atm.exampleremains as useful way to revert params to sensible Project author defined value if the user borks their configure.Checklist