Make build no-network - #138
Open
brikin01 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enforces network isolation for final MCP image builds.
Changes:
- Disables networking in Dockerfile, release, integration, and local builds.
- Adds policy tests and removes redundant action-pin testing.
- Documents build-input rollback procedures.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates local build and rollback guidance. |
mcp-local/Dockerfile |
Marks remaining RUN instructions network-disabled. |
mcp-local/tests/test_build_inputs.py |
Adds network-isolation policy coverage. |
.github/workflows/integration-tests.yml |
Disables build networking across architectures. |
.github/workflows/build-mcp-image.yml |
Disables networking for release builds. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fulfills STESOL-572
Summary
Enforces network-isolated
RUNinstructions when building the final MCP image. Also reintroduces the weekly embeddings build on Sundays (at 09:17 UTC), producing a promotion PR ready for review on Monday.network: noneto the release build.--network noneto AMD64 and Arm64 integration builds.RUNinstruction with--network=none.The action-pin unit test was removed because the repository now enables GitHub’s Require actions to be pinned to a full-length commit SHA setting. This centrally enforces the rule across every workflow.
Guarantee and scope
Commands executed by final-image
RUNinstructions cannot access the network and must use the prepared, digest-pinned build inputs. BuildKit may still contact registries (i.e. GHCR) to pull those pinned images.Validation
Release workflow dry run succeeded: https://github.com/arm/mcp/actions/runs/32075135766