Reduce the last PicoLibC patch to only what we need for now. - #991
Open
MarkMurrayARM wants to merge 2 commits into
Open
Reduce the last PicoLibC patch to only what we need for now.#991MarkMurrayARM wants to merge 2 commits into
MarkMurrayARM wants to merge 2 commits into
Conversation
Reduce this last patch to only what we need for now. I've added a comment to the bit that Keith Packhard may accept, but I'll let it mellow here for a day or three first.
statham-arm
reviewed
Aug 6, 2026
statham-arm
left a comment
statham-arm
left a comment
Contributor
There was a problem hiding this comment.
LGTM but I spotted a nit
Comment on lines
+39
to
+40
| + /* This is used by C++ library to determine if new(), etc is overridden or not in situationr | ||
| + * when direct pointer comparison does not work, e.g. with PAC pointers are signed, thus haver |
Contributor
There was a problem hiding this comment.
Nit: there's a spurious r at the end of both of those comment lines!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to the last PicoLibC patch
Reduce this last patch to only what we need for now.
I've added a comment to the bit that Keith Packhard may accept,
but I'll let it mellow here for a day or three first.