Fix mismatched lifetime syntax warnings - #172
Closed
weikengchen wants to merge 1 commit into
Closed
Conversation
weikengchen
requested review from
Pratyush,
WizardOfMenlo,
mmagician and
z-tech
and removed request for
a team
August 31, 2026 02:32
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sonic_pc::CommitterKey::{powers, shifted_powers}explicitkzg10test-only trim helper-D warningsbenchmark check after themismatched_lifetime_syntaxeslint became activeThis is a type-signature-only change and does not alter runtime behavior.
Validation
cargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo +nightly check --all-features --examples --all --benchesRUSTFLAGS="-D warnings" cargo +nightly test --release(113 passed; 4 doc tests passed, 3 ignored)The
kzg10test helper is included because it exposes the same lint after the twosonic_pcdiagnostics are fixed; omitting it would leave the nightly CI path failing.