Skip to content

fix(zip): translate forceUTC option to forceLocalTime for zip-stream #860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hooiv wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −1
Draft

fix(zip): translate forceUTC option to forceLocalTime for zip-stream #860

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion lib/plugins/zip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ export default class Zip {
constructor(options) {
options = this.options = {
comment: "",
forceUTC: false,
namePrependSlash: false,
store: false,
...options,
};
if (
typeof options.forceUTC === "boolean" &&
typeof options.forceLocalTime === "undefined"
) {
options.forceLocalTime = !options.forceUTC;
}
this.engine = new engine(options);
}
/**
Expand Down
13 changes: 13 additions & 0 deletions test/plugins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,5 +256,18 @@ describe("plugins", function () {
it("should allow for archive comment", function () {
assert.equal("archive comment", zipComment);
});
it("should translate forceUTC option to forceLocalTime on engine", function () {
var zipUtc = new ZipArchive({ forceUTC: true });
assert.equal(zipUtc._module.options.forceLocalTime, false);

var zipLocal = new ZipArchive({ forceUTC: false });
assert.equal(zipLocal._module.options.forceLocalTime, true);

var zipExplicitLocal = new ZipArchive({
forceLocalTime: true,
forceUTC: true,
});
assert.equal(zipExplicitLocal._module.options.forceLocalTime, true);
});
});
});