Set monitor.prometheus.exporter.port on kubedb editor charts - #1105
Merged
Conversation
Each database's exporter port is hardcoded to match the default set by its operator's SetDefaults() (kubedb.dev/apimachinery), so the rendered CR always carries an explicit port instead of relying on the operator default. neo4j and qdrant previously exposed this as a user-overridable value; switched them to the same hardcoded pattern as the rest for consistency. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-exp-port
branch
from
July 31, 2026 11:49
d62ef1b to
c135579
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec.monitor.prometheus.exporter.portindb.yamlfor 22 kubedb editor charts, matching the default port each operator sets viaSetDefaults()in kubedb.dev/apimachinery.portas a user-overridable values.yaml field; switched to the same hardcoded pattern as the rest for consistency, and removed the now-unusedport: 0from theirvalues.yaml.Excluded:
db2,documentdb: noMonitorfield in their kubedb CRD spec.hanadb,hazelcast,ignite,milvus,oracle,weaviate:db.yamldoesn't render amonitor:block at all currently (pre-existing gap, separate from this change).Test plan
go build ./...helm templatespot-checked across several charts (mongodb, rabbitmq, pgpool, zookeeper, neo4j, qdrant) with monitoring enabled — port renders correctly