docs(plugin-types): fix stale 2.4.x claims in README + namespaces.ts header - #7
Conversation
…header
- README: 22 namespaces/33 permissions -> 43 namespaces / 135-scope union;
usage example now type-checks against the published 3.0.0 surface
(ctx.fs.home() and ctx.ui.notify({title,body}) never existed; Permission
is exported as PermissionScope; real calls: ctx.fileOps.getActiveDirectory()
+ ctx.ui.showNotification({message}))
- namespaces.ts header: 'all 22 namespaces' -> 'the 22 host-core namespaces'
with a pointer to namespaces-core-plugins.ts (43 total on PluginContext);
@Version 2.4.0-fn50 -> 3.0.0 (matches core.ts/permissions.ts/
namespaces-core-plugins.ts headers)
The stale header is baked into the PUBLISHED 3.0.0 tarball's
dist/namespaces.d.ts — immutable at 3.0.0 (no republish); this source fix
means the next release carries the correction. Found by fn-165.1's
knowledge-refresh audit.
Task: fn-165.5
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b1a18b01a6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- README: legacy-alias bullet qualified per src/permissions.ts — only network.fetch is host-normalized; network/smartFolders/webview have no host entry; shell.uncontained never declarable
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34de6da55a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- README: name the dynamic oauth.${string} scope family; '135-scope' now refers only to the canonical fixed set
1 participant
What
Two stale-doc fixes on
packages/plugin-types, found by fn-165.1's knowledge-refresh audit:README.md— still claimed "all 22 plugin namespaces and 33 permissions" and its usage example called phantom APIs:ctx.fs.home()andctx.ui.notify({title, body})never existed on the published surface, and it imported a non-existentPermissiontype. Now: 43 namespaces / 135-scope union, and the example uses the real surface —ctx.fileOps.getActiveDirectory()+ctx.ui.showNotification({message})+PermissionScope— verified to type-check against the built dist (tsc --strict --noEmitwith the package path-mapped).src/namespaces.tsheader (lines 2 + 5) — still read "all 22 namespaces" /@version 2.4.0-fn50. This stale header is baked into the PUBLISHED 3.0.0 tarball'sdist/namespaces.d.ts(immutable at 3.0.0 — no republish). Fixed at the source ("the 22 host-core namespaces", pointer tonamespaces-core-plugins.ts,@version 3.0.0matching the sibling module headers) so the next release carries the correction.Verification
npm run build+npm test(bothtscprojects) passdist/index.d.ts: cleanc96d9a3): SHIP r1Notes