feat: support dragHandle="inside" on reorderable HasManyFields#1331
Open
theovelikov wants to merge 2 commits into
Open
feat: support dragHandle="inside" on reorderable HasManyFields#1331theovelikov wants to merge 2 commits into
theovelikov wants to merge 2 commits into
Conversation
Contributor
|
Released prerelease version |
JeremyRH
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two additive props on
HasManyFields:dragHandle="inside"— renders the reorderable drag handle inside eachHasManyFieldsRow(before the row content) instead of prepending it outside the row.rowClassName— passed through asclassNameto eachHasManyFieldsRow(which already accepts it), e.g."border rounded p-3"for a card-style row.Together they enable card-style reorderable rows: border wrapping handle + content + delete button.
Why
With the current layout, the handle sits to the left of the row inside the same column as the row content, indenting every reorderable row by ~2rem. In forms where reorderable rows sit alongside regular inputs (e.g. Property's owner packet settings and owner packet send flow), the rows no longer align with the other fields. Current UX designs place the handle inside a bordered row card spanning the full column.
Risk
Low — defaults (
dragHandle="outside", norowClassName) preserve the existing markup; the new layout only applies to consumers that opt in. Covered by new jest cases for both handle placements and the row class pass-through.🤖 Generated with Claude Code