fix: add fixedWidth to SelectMultiValue remove icon - #1330
Merged
Conversation
The chip's remove glyph (fa-xmark) had no fixed width, so its intrinsic advance-width shifts with Font Awesome version/metric changes, reflowing chip widths and the multi-value control's hit-target geometry. Co-authored-by: Aaron Mars <aaron.mars@appfolio.com>
aaronmars
approved these changes
Jul 21, 2026
Contributor
|
Released prerelease version |
Author
|
Hi! I couldn't find an account linked to your GitHub profile (@github-actions[bot]). |
aaronmars
changed the title
|
Jira Issue: https://appfolio.atlassian.net/browse/FEE-1912 |
aaronmars
marked this pull request as ready for review
July 21, 2026 15:24
supernova-dx-appf-io
Bot
changed the title
JeremyRH
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Font Awesome 6.7.2 compatibility issue with SelectMultiValue remove icon causing unintended selection removal.
Problem
After upgrading Font Awesome from 6.2.0 to 6.7.2, multi-select chips in SelectMultiValue were losing their selected values unexpectedly. The 4th selected item in particular would be removed when clicking the remove "×" icon. This was caused by variable icon widths in Font Awesome 6.7.2, which shifted the clickable area of the remove button, causing unintended interactions with adjacent elements.
Solution
Added
fixedWidthattribute to the remove icon in SelectMultiValue component. This ensures the icon maintains a consistent, predictable width across Font Awesome versions, stabilizing the chip geometry and preventing click target misalignment.Changes
fixedWidthprop to the remove icon (xmark) inSelectMultiValue.jsTesting
Agent session: https://supernova.dx.appf.io/coders/87ad5c34-c03e-4407-a0f5-8fac8c55cc37