fix(sync): handle missing position events without breaking sync stream#6489
Open
VuMartin wants to merge 3 commits into
Open
fix(sync): handle missing position events without breaking sync stream#6489VuMartin wants to merge 3 commits into
VuMartin wants to merge 3 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6489 +/- ##
============================================
+ Coverage 69.83% 70.31% +0.47%
Complexity 3383 3383
============================================
Files 1142 1142
Lines 44844 44872 +28
Branches 4949 4955 +6
============================================
+ Hits 31318 31550 +232
+ Misses 11874 11682 -192
+ Partials 1652 1640 -12
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR fixes an issue where a missing position entry could break the position synchronization stream during collaborative editing.
Instead of allowing an
undefinedold position to propagate, the position change event is filtered out so the stream continues processing future valid events.Before (simulated missing position scenario):
If a position change event was received for an operator whose position was missing from
elementPositions, the stream could error out and stop processing future position updates, breaking synchronization.After:
Position change events with missing position information are ignored, allowing the stream to continue processing subsequent valid position updates and preserving synchronization.
Any related issues, documentation, discussions?
Closes #6420
How was this PR tested?
Manual test:
Added a unit test that simulates a missing position entry by removing an operator's position from the internal position map before triggering a position change. The test verifies that the invalid event is ignored and that subsequent valid position change events are still emitted correctly.
Ran:
yarn test --include=src/app/workspace/service/workflow-graph/model/joint-graph-wrapper.spec.tsWas this PR authored or co-authored using generative AI tooling?
Generated-by: ChatGPT (GPT-5.5 mini)