test(frontend): add unit tests for AuthService#6470
Open
Ma77Ball wants to merge 2 commits into
Open
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6470 +/- ##
============================================
+ Coverage 70.20% 70.29% +0.08%
Complexity 3390 3390
============================================
Files 1142 1142
Lines 44844 44871 +27
Branches 4949 4955 +6
============================================
+ Hits 31484 31542 +58
+ Misses 11725 11692 -33
- Partials 1635 1637 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/request-review @aglinxinyuan |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Vitest spec to improve frontend unit-test coverage for the AuthService user-authentication helper/service without modifying production code. This supports the broader Angular frontend by validating client-side auth request shapes and local token handling behavior.
Changes:
- Added
auth.service.spec.tscovering static access-token helpers (set/get/remove) and logout behavior. - Added HTTP request assertions for
register(),auth()andgoogleAuth()endpoint calls. - Added branch coverage for
loginWithExistingToken()(no token, expired token, valid token, invite-only inactive user flow).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+81
to
+84
| afterEach(() => { | ||
| httpMock.verify(); | ||
| localStorage.clear(); | ||
| }); |
Comment on lines
+103
to
+107
| describe("HTTP auth endpoints", () => { | ||
| it("register() POSTs username/password to the register endpoint", () => { | ||
| service.register("alice", "pw").subscribe(); | ||
| const req = httpMock.expectOne(`${api}/${AuthService.REGISTER_ENDPOINT}`); | ||
| expect(req.request.method).toEqual("POST"); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6458
How was this PR tested?
cd frontend && npx nx test gui --include="**/auth.service.spec.ts", expect 10 passed.yarn test:ci, selected by the auto-appliedfrontendlabel.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF