test(frontend): add unit tests for ComputingUnitActionsService#6468
Conversation
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6468 +/- ##
============================================
+ Coverage 70.20% 70.28% +0.07%
Complexity 3390 3390
============================================
Files 1142 1142
Lines 44844 44871 +27
Branches 4949 4955 +6
============================================
+ Hits 31484 31537 +53
+ Misses 11725 11696 -29
- Partials 1635 1638 +3
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/request-review @aglinxinyuan |
There was a problem hiding this comment.
Pull request overview
This PR adds Vitest-based unit test coverage for ComputingUnitActionsService in the Angular frontend, addressing the gap described in #6456 without changing production code.
Changes:
- Adds a new spec file covering
create()routing for kubernetes/local requests and unsupported types. - Adds tests for
openShareAccessModal()to validate the modal seed data and default parameter behavior. - Adds tests for
confirmAndTerminate()covering invalid units, opening the confirmation modal, and success/failure notification behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6456
How was this PR tested?
cd frontend && npx nx test gui --include="**/computing-unit-actions.service.spec.ts", expect 10 passed.yarn test:ci, selected by the auto-appliedfrontendlabel.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF