test(frontend): add unit tests for WorkflowSnapshotService#6466
Open
Ma77Ball wants to merge 2 commits into
Open
test(frontend): add unit tests for WorkflowSnapshotService#6466Ma77Ball wants to merge 2 commits into
Ma77Ball wants to merge 2 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6466 +/- ##
============================================
- Coverage 70.20% 70.20% -0.01%
Complexity 3390 3390
============================================
Files 1142 1142
Lines 44844 44844
Branches 4949 4949
============================================
- Hits 31484 31481 -3
- Misses 11725 11726 +1
- Partials 1635 1637 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+28
to
+30
| // createSnapShotCanvas() delegates to html2canvas, whose module-level mock is not | ||
| // reliable here (other specs import it unmocked and the builder shares one module | ||
| // registry), so it is exercised in the e2e/browser suite rather than pinned here. |
Comment on lines
+52
to
+72
| describe("uploadWorkflowSnapshot", () => { | ||
| it("PUTs a multipart form with the blob and stringified wid", () => { | ||
| const blob = new Blob(["img"], { type: "image/png" }); | ||
| service.uploadWorkflowSnapshot(blob, 12).subscribe(); | ||
|
|
||
| const req = httpMock.expectOne(WORKFLOW_SNAPSHOT_UPLOAD_URL); | ||
| expect(req.request.method).toEqual("PUT"); | ||
| const body = req.request.body as FormData; | ||
| expect(body.get("wid")).toEqual("12"); | ||
| expect(body.get("SnapshotBlob")).toBeInstanceOf(Blob); | ||
| req.flush({}); | ||
| }); | ||
|
|
||
| it("sends an empty wid string when wid is undefined", () => { | ||
| service.uploadWorkflowSnapshot(new Blob([]), undefined).subscribe(); | ||
|
|
||
| const req = httpMock.expectOne(WORKFLOW_SNAPSHOT_UPLOAD_URL); | ||
| expect((req.request.body as FormData).get("wid")).toEqual(""); | ||
| req.flush({}); | ||
| }); | ||
| }); |
Contributor
|
is this service even used? it might be dead code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Any related issues, documentation, discussions?
Closes: #6454
How was this PR tested?
cd frontend && npx nx test gui --include="**/workflow-snapshot.service.spec.ts", expect 6 passed.yarn test:ci, selected by the auto-appliedfrontendlabel.Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude Opus 4.8 in compliance with ASF