fix(deps, pyamber): bump setuptools from 80.10.2 to 83.0.0 in /amber#6412
fix(deps, pyamber): bump setuptools from 80.10.2 to 83.0.0 in /amber#6412dependabot[bot] wants to merge 4 commits into
Conversation
Bumps [setuptools](https://github.com/pypa/setuptools) from 80.10.2 to 83.0.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/NEWS.rst) - [Commits](pypa/setuptools@v80.10.2...v83.0.0) --- updated-dependencies: - dependency-name: setuptools dependency-version: 83.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Automated Reviewer SuggestionsBased on the
|
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 396 | 0.242 | 24,260/33,118/33,118 us | 🔴 -6.4% / 🔴 +128.6% |
| ⚪ | bs=100 sw=10 sl=64 | 798 | 0.487 | 122,444/146,236/146,236 us | ⚪ within ±5% / 🔴 +45.5% |
| 🔴 | bs=1000 sw=10 sl=64 | 928 | 0.566 | 1,068,933/1,212,264/1,212,264 us | 🔴 +8.9% / 🔴 +25.3% |
Baseline details
Latest main 2e5c99c from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 396 tuples/sec | 423 tuples/sec | 830.77 tuples/sec | -6.4% | -52.3% |
| bs=10 sw=10 sl=64 | MB/s | 0.242 MB/s | 0.258 MB/s | 0.507 MB/s | -6.2% | -52.3% |
| bs=10 sw=10 sl=64 | p50 | 24,260 us | 24,465 us | 11,905 us | -0.8% | +103.8% |
| bs=10 sw=10 sl=64 | p95 | 33,118 us | 31,757 us | 14,486 us | +4.3% | +128.6% |
| bs=10 sw=10 sl=64 | p99 | 33,118 us | 31,757 us | 19,430 us | +4.3% | +70.4% |
| bs=100 sw=10 sl=64 | throughput | 798 tuples/sec | 822 tuples/sec | 1,082 tuples/sec | -2.9% | -26.3% |
| bs=100 sw=10 sl=64 | MB/s | 0.487 MB/s | 0.502 MB/s | 0.66 MB/s | -3.0% | -26.3% |
| bs=100 sw=10 sl=64 | p50 | 122,444 us | 121,869 us | 93,412 us | +0.5% | +31.1% |
| bs=100 sw=10 sl=64 | p95 | 146,236 us | 148,661 us | 100,489 us | -1.6% | +45.5% |
| bs=100 sw=10 sl=64 | p99 | 146,236 us | 148,661 us | 111,365 us | -1.6% | +31.3% |
| bs=1000 sw=10 sl=64 | throughput | 928 tuples/sec | 935 tuples/sec | 1,104 tuples/sec | -0.7% | -15.9% |
| bs=1000 sw=10 sl=64 | MB/s | 0.566 MB/s | 0.571 MB/s | 0.674 MB/s | -0.9% | -16.0% |
| bs=1000 sw=10 sl=64 | p50 | 1,068,933 us | 1,064,433 us | 925,459 us | +0.4% | +15.5% |
| bs=1000 sw=10 sl=64 | p95 | 1,212,264 us | 1,112,934 us | 967,138 us | +8.9% | +25.3% |
| bs=1000 sw=10 sl=64 | p99 | 1,212,264 us | 1,112,934 us | 997,758 us | +8.9% | +21.5% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,505.15,200,128000,396,0.242,24259.85,33117.63,33117.63
1,100,10,64,20,2504.92,2000,1280000,798,0.487,122443.60,146235.79,146235.79
2,1000,10,64,20,21556.67,20000,12800000,928,0.566,1068933.19,1212263.53,1212263.53
There was a problem hiding this comment.
Pull request overview
This PR updates the Amber (pyamber) Python dependency pin for setuptools to the latest specified version, keeping the Amber Python environment current and consistent with the project’s pinned-dependency approach.
Changes:
- Bump
setuptoolsfrom80.10.2to83.0.0inamber/requirements.txt.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
============================================
+ Coverage 69.90% 70.16% +0.26%
- Complexity 3380 3385 +5
============================================
Files 1142 1142
Lines 44844 44844
Branches 4949 4949
============================================
+ Hits 31346 31465 +119
+ Misses 11849 11739 -110
+ Partials 1649 1640 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| # Not imported directly: `fs` needs pkg_resources at import time (#4199). | ||
| setuptools==80.10.2 | ||
| setuptools==83.0.0 |
There was a problem hiding this comment.
why do we need to keep setuptools again?
There was a problem hiding this comment.
We do not import setuptools directly in Texera. It is kept because PyAmber imports PyFilesystem2 (fs) in amber/src/main/python/core/architecture/managers/executor_manager.py, and fs==2.4.16 imports pkg_resources at module import time. pkg_resources is provided by setuptools, so the requirement keeps that indirect import available.
There was a problem hiding this comment.
can we just remove setuptools? if fs depends on pkg_resources, then it should declare pkg_resources as its dependency?
aglinxinyuan
changed the title
|
👋 Thanks for opening this pull request, @dependabot[bot]! It looks like the pull request description doesn't quite follow our template yet:
Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed. You can find the template prompts by editing the description, or see CONTRIBUTING.md for the full contribution flow. |
This reverts commit 6d768f4.
aglinxinyuan
changed the title
Bumps setuptools from
80.10.2to83.0.0in/amber.Context for the existing dependency entry: Texera does not import
setuptoolsdirectly. PyAmber imports PyFilesystem2 (fs) inamber/src/main/python/core/architecture/managers/executor_manager.py, andfs==2.4.16importspkg_resourcesat module import time.pkg_resourcesis provided bysetuptools, which is whysetuptoolsis listed inamber/requirements.txt.