Add support for Java records and Optional serialization in the JSON plugin.#1792
Open
srilakshmikanthanp wants to merge 2 commits into
Open
Add support for Java records and Optional serialization in the JSON plugin.#1792srilakshmikanthanp wants to merge 2 commits into
srilakshmikanthanp wants to merge 2 commits into
Conversation
Member
|
Please create a JIRA ticket first https://issues.apache.org/jira/projects/WW/ |
Author
|
Thanks! I've requested an Apache JIRA account. Once it's approved, I'll create the JIRA issue and update this PR with the issue number. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordComponentmetadata, asIntrospector.getBeanInfo()does not expose record components through the traditional JavaBeans property model.java.util.Optionalnow serializes as its contained value ornullwhen empty.Optional.empty()is treated asnullwhenexcludeNullPropertiesis enabled, including for bean/record properties and map values.@JSONand@JSONFieldBridgeannotations can now be applied directly to record components.I implemented these changes based on my understanding of the existing codebase and tried to keep the implementation minimal and consistent with the current design.
I'd appreciate a review of the implementation and approach. If you'd like any changes, please let me know and I'll update the PR.